As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Snippets Groups Projects

errors.rb

6 years ago

Remove circular dependency between HTTPHelper and GitlabNet · b4f6fbd8

Stan Hu authored 6 years ago

HttpHelper depended on exceptions defined in GitLabNet, but GitLabNet
included HttpHelper. Specs in Ruby 2.5 were breaking as a result of
Action::Custom not able to reference constants in GitLabNet:
https://gitlab.com/gitlab-org/gitlab-shell/-/jobs/126362702.

Closes https://gitlab.com/gitlab-org/gitlab-shell/issues/169

b4f6fbd8

Remove circular dependency between HTTPHelper and GitlabNet

Stan Hu authored 6 years ago

HttpHelper depended on exceptions defined in GitLabNet, but GitLabNet
included HttpHelper. Specs in Ruby 2.5 were breaking as a result of
Action::Custom not able to reference constants in GitLabNet:
https://gitlab.com/gitlab-org/gitlab-shell/-/jobs/126362702.

Closes https://gitlab.com/gitlab-org/gitlab-shell/issues/169

Code owners

Assign users and groups as approvers for specific file changes. Learn more.

As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.