httpsclient_test.go

3 years ago

Only validate SSL cert file exists if a value is supplied · d2f64237

Stan Hu authored 3 years ago

This fixes a regression in
https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/508. If an
HTTPS internal API URL were used, gitlab-shell would not work at all. We
now handle blank `caFile` properly.

Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/529

Unverified

d2f64237

History

Only validate SSL cert file exists if a value is supplied

Stan Hu authored 3 years ago

This fixes a regression in
https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/508. If an
HTTPS internal API URL were used, gitlab-shell would not work at all. We
now handle blank `caFile` properly.

Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/529

Code owners

Assign users and groups as approvers for specific file changes. Learn more.