Prefer t.TempDir() over os.MkdirTemp()

0c12d7e5 · Ash McKenzie · b7106f34 · 0c12d7e5
Unverified Commit 0c12d7e5 authored 1 year ago by Ash McKenzie
--- a/internal/testhelper/testhelper.go
+++ b/internal/testhelper/testhelper.go
@@ -28,10 +28,7 @@ func TempEnv(env map[string]string) func() {
 func PrepareTestRootDir(t *testing.T) string {
 	t.Helper()

-	testRoot, err := os.MkdirTemp("", "root")
-	require.NoError(t, err)
-	require.NoError(t, os.MkdirAll(testRoot, 0700))
-
+	testRoot := t.TempDir()
 	t.Cleanup(func() { require.NoError(t, os.RemoveAll(testRoot)) })

 	require.NoError(t, copyTestData(testRoot))