As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
Unverified Commit 29b1a529 authored by Ash McKenzie's avatar Ash McKenzie
Browse files

Comment Client public methods and drop oid

parent 4fc58f1c
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -168,7 +168,8 @@ func (c *Client) Batch(operation string, reqObjects []*BatchObject, ref string,
return response, nil
}
func (c *Client) GetObject(oid, href string, headers map[string]string) (io.ReadCloser, int64, error) {
// GetObject performs an HTTP GET request for the object
func (c *Client) GetObject(_, href string, headers map[string]string) (io.ReadCloser, int64, error) {
req, _ := newHTTPRequest(http.MethodGet, href, nil)
for key, value := range headers {
req.Header.Add(key, value)
Loading
Loading
@@ -188,7 +189,8 @@ func (c *Client) GetObject(oid, href string, headers map[string]string) (io.Read
return res.Body, res.ContentLength, nil
}
func (c *Client) PutObject(oid, href string, headers map[string]string, r io.Reader) error {
// PutObject performs an HTTP PUT request for the object
func (c *Client) PutObject(_, href string, headers map[string]string, r io.Reader) error {
req, _ := newHTTPRequest(http.MethodPut, href, r)
for key, value := range headers {
req.Header.Add(key, value)
Loading
Loading
Loading
Loading
@@ -396,11 +396,9 @@ internal/gitlabnet/lfstransfer/client.go:104:5: exported: exported var ClientHea
internal/gitlabnet/lfstransfer/client.go:106:1: exported: exported function NewClient should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:124:1: exported: exported method Client.Batch should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:125: internal/gitlabnet/lfstransfer/client.go:125: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: This causes tests to fail" (godox)
internal/gitlabnet/lfstransfer/client.go:171:28: unused-parameter: parameter 'oid' seems to be unused, consider removing or renaming it as _ (revive)
internal/gitlabnet/lfstransfer/client.go:191:28: unused-parameter: parameter 'oid' seems to be unused, consider removing or renaming it as _ (revive)
internal/gitlabnet/lfstransfer/client.go:212:1: exported: exported method Client.Lock should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:269:1: exported: exported method Client.Unlock should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:319:1: exported: exported method Client.ListLocksVerify should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:214:1: exported: exported method Client.Lock should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:271:1: exported: exported method Client.Unlock should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:321:1: exported: exported method Client.ListLocksVerify should have comment or be unexported (revive)
internal/gitlabnet/personalaccesstoken/client_test.go:30:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/twofactorrecover/client_test.go:30:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/twofactorverify/client_test.go:24:3: go-require: do not use require in http handlers (testifylint)
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment