As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
Unverified Commit 477e92d7 authored by Ash McKenzie's avatar Ash McKenzie
Browse files

Rename to setupWaitGroupForExecute() for clarity

parent a8f50019
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -38,7 +38,7 @@ var (
evenLargerFileOid = hex.EncodeToString(evenLargerFileHash[:])
)
func setupWaitGroup(t *testing.T, cmd *Command) *sync.WaitGroup {
func setupWaitGroupForExecute(t *testing.T, cmd *Command) *sync.WaitGroup {
wg := &sync.WaitGroup{}
wg.Add(1)
Loading
Loading
@@ -259,7 +259,7 @@ func quit(t *testing.T, pl *pktline.Pktline) {
func TestLfsTransferCapabilities(t *testing.T) {
_, cmd, pl, _ := setup(t, "rw", "group/repo", "upload")
wg := setupWaitGroup(t, cmd)
wg := setupWaitGroupForExecute(t, cmd)
negotiateVersion(t, pl)
quit(t, pl)
Loading
Loading
@@ -274,7 +274,7 @@ func TestLfsTransferNoPermissions(t *testing.T) {
func TestLfsTransferBatchDownload(t *testing.T) {
url, cmd, pl, _ := setup(t, "rw", "group/repo", "download")
wg := setupWaitGroup(t, cmd)
wg := setupWaitGroupForExecute(t, cmd)
negotiateVersion(t, pl)
writeCommandArgsAndTextData(t, pl, "batch", nil, []string{
Loading
Loading
@@ -340,7 +340,7 @@ func TestLfsTransferBatchDownload(t *testing.T) {
func TestLfsTransferBatchUpload(t *testing.T) {
_, cmd, pl, _ := setup(t, "rw", "group/repo", "upload")
wg := setupWaitGroup(t, cmd)
wg := setupWaitGroupForExecute(t, cmd)
negotiateVersion(t, pl)
writeCommandArgsAndTextData(t, pl, "batch", nil, []string{
Loading
Loading
@@ -359,7 +359,7 @@ func TestLfsTransferBatchUpload(t *testing.T) {
func TestLfsTransferGetObject(t *testing.T) {
_, cmd, pl, _ := setup(t, "rw", "group/repo", "download")
wg := setupWaitGroup(t, cmd)
wg := setupWaitGroupForExecute(t, cmd)
negotiateVersion(t, pl)
writeCommand(t, pl, "get-object 00000000")
Loading
Loading
@@ -376,7 +376,7 @@ func TestLfsTransferGetObject(t *testing.T) {
func TestLfsTransferPutObject(t *testing.T) {
_, cmd, pl, _ := setup(t, "rw", "group/repo", "upload")
wg := setupWaitGroup(t, cmd)
wg := setupWaitGroupForExecute(t, cmd)
negotiateVersion(t, pl)
writeCommandArgsAndBinaryData(t, pl, "put-object 00000000", []string{"size=0"}, nil)
Loading
Loading
@@ -393,7 +393,7 @@ func TestLfsTransferPutObject(t *testing.T) {
func TestLfsTransferVerifyObject(t *testing.T) {
_, cmd, pl, _ := setup(t, "rw", "group/repo", "upload")
wg := setupWaitGroup(t, cmd)
wg := setupWaitGroupForExecute(t, cmd)
negotiateVersion(t, pl)
writeCommandArgs(t, pl, "verify-object 00000000", []string{"size=0"})
Loading
Loading
@@ -410,7 +410,7 @@ func TestLfsTransferVerifyObject(t *testing.T) {
func TestLfsTransferLock(t *testing.T) {
_, cmd, pl, _ := setup(t, "rw", "group/repo", "upload")
wg := setupWaitGroup(t, cmd)
wg := setupWaitGroupForExecute(t, cmd)
negotiateVersion(t, pl)
writeCommandArgs(t, pl, "lock", []string{"path=large/file"})
Loading
Loading
@@ -427,7 +427,7 @@ func TestLfsTransferLock(t *testing.T) {
func TestLfsTransferUnlock(t *testing.T) {
_, cmd, pl, _ := setup(t, "rw", "group/repo", "upload")
wg := setupWaitGroup(t, cmd)
wg := setupWaitGroupForExecute(t, cmd)
negotiateVersion(t, pl)
writeCommand(t, pl, "unlock lock1")
Loading
Loading
@@ -444,7 +444,7 @@ func TestLfsTransferUnlock(t *testing.T) {
func TestLfsTransferListLock(t *testing.T) {
_, cmd, pl, _ := setup(t, "rw", "group/repo", "download")
wg := setupWaitGroup(t, cmd)
wg := setupWaitGroupForExecute(t, cmd)
negotiateVersion(t, pl)
writeCommand(t, pl, "list-lock")
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment