As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
Unverified Commit 5b34a1b0 authored by Ash McKenzie's avatar Ash McKenzie
Browse files

Check in list of known linter errors

parent 5eef546a
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
support/lint_last_known_acceptable.txt 0 → 100644
+ 445
− 0
View file @ 5b34a1b0
client/client_test.go:24:2: var-naming: var defaultHttpOpts should be defaultHTTPOpts (revive)
client/client_test.go:114:3: expected-actual: need to reverse actual and expected values (testifylint)
client/client_test.go:136:30: response body must be closed (bodyclose)
client/client_test.go:142:31: response body must be closed (bodyclose)
client/client_test.go:150:30: response body must be closed (bodyclose)
client/client_test.go:156:31: response body must be closed (bodyclose)
client/client_test.go:164:30: response body must be closed (bodyclose)
client/client_test.go:170:31: response body must be closed (bodyclose)
client/client_test.go:182:72: unused-parameter: parameter 'token' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:243:5: go-require: do not use require in http handlers (testifylint)
client/client_test.go:251:5: go-require: do not use require in http handlers (testifylint)
client/client_test.go:256:5: go-require: do not use require in http handlers (testifylint)
client/client_test.go:275:41: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:286:18: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:304:73: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
client/client_test.go:316:21: response body must be closed (bodyclose)
client/httpclient.go:209:22: G115: integer overflow conversion uint64 -> int64 (gosec)
client/httpclient_test.go:37:5: go-require: do not use require in http handlers (testifylint)
client/httpclient_test.go:45:5: go-require: do not use require in http handlers (testifylint)
client/httpclient_test.go:85:5: go-require: do not use require in http handlers (testifylint)
client/httpclient_test.go:103:5: go-require: do not use require in http handlers (testifylint)
client/httpclient_test.go:109:5: go-require: do not use require in http handlers (testifylint)
client/httpsclient_test.go:62:4: expected-actual: need to reverse actual and expected values (testifylint)
client/httpsclient_test.go:105:24: response body must be closed (bodyclose)
client/httpsclient_test.go:108:5: expected-actual: need to reverse actual and expected values (testifylint)
client/httpsclient_test.go:119:5: go-require: do not use require in http handlers (testifylint)
client/testserver/gitalyserver.go:1:1: package-comments: should have a package comment (revive)
client/testserver/gitalyserver.go:21:6: exported: exported type TestGitalyServer should have comment or be unexported (revive)
client/testserver/gitalyserver.go:26:1: exported: exported method TestGitalyServer.SSHReceivePack should have comment or be unexported (revive)
client/testserver/gitalyserver.go:38:1: exported: exported method TestGitalyServer.SSHUploadPack should have comment or be unexported (revive)
client/testserver/gitalyserver.go:50:1: exported: exported method TestGitalyServer.SSHUploadPackWithSidechannel should have comment or be unexported (revive)
client/testserver/gitalyserver.go:55:18: Error return value of `conn.Close` is not checked (errcheck)
client/testserver/gitalyserver.go:70:1: exported: exported method TestGitalyServer.SSHUploadArchive should have comment or be unexported (revive)
client/testserver/gitalyserver.go:82:1: exported: exported function StartGitalyServer should have comment or be unexported (revive)
client/testserver/gitalyserver.go:131:3: go-require: require must only be used in the goroutine running the test function (testifylint)
client/testserver/testserver.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
client/testserver/testserver.go:20:6: exported: exported type TestRequestHandler should have comment or be unexported (revive)
client/testserver/testserver.go:25:1: exported: exported function StartSocketHttpServer should have comment or be unexported (revive)
client/testserver/testserver.go:45:12: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
client/testserver/testserver.go:51:17: Error return value of `server.Serve` is not checked (errcheck)
client/testserver/testserver.go:58:1: exported: exported function StartHttpServer should have comment or be unexported (revive)
client/testserver/testserver.go:67:1: exported: exported function StartRetryHttpServer should have comment or be unexported (revive)
client/testserver/testserver.go:95:1: exported: exported function StartHttpsServer should have comment or be unexported (revive)
client/testserver/testserver.go:113:18: G304: Potential file inclusion via variable (gosec)
client/transport.go:58:1: exported: exported function DefaultTransport should have comment or be unexported (revive)
client/transport.go:62:1: exported: exported function NewTransport should have comment or be unexported (revive)
cmd/gitlab-shell-authorized-keys-check/main.go:40:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
cmd/gitlab-shell-authorized-keys-check/main.go:43:13: unnecessary conversion (unconvert)
cmd/gitlab-shell-authorized-principals-check/command/command.go:1:1: package-comments: should have a package comment (revive)
cmd/gitlab-shell-authorized-principals-check/command/command.go:12:1: exported: exported function New should have comment or be unexported (revive)
cmd/gitlab-shell-authorized-principals-check/command/command.go:25:1: exported: exported function Parse should have comment or be unexported (revive)
cmd/gitlab-shell-authorized-principals-check/main.go:1:1: package-comments: should have a package comment (revive)
cmd/gitlab-shell-authorized-principals-check/main.go:34:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
cmd/gitlab-shell-authorized-principals-check/main.go:40:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
cmd/gitlab-shell-authorized-principals-check/main.go:45:23: Error return value of `logCloser.Close` is not checked (errcheck)
cmd/gitlab-shell-authorized-principals-check/main.go:51:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
cmd/gitlab-shell-authorized-principals-check/main.go:52:3: exitAfterDefer: os.Exit will exit, and `defer logCloser.Close()` will not run (gocritic)
cmd/gitlab-shell-authorized-principals-check/main.go:58:5: ineffectual assignment to ctx (ineffassign)
cmd/gitlab-shell-check/main.go:1:1: package-comments: should have a package comment (revive)
cmd/gitlab-shell-check/main.go:33:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
cmd/gitlab-shell-check/main.go:39:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
cmd/gitlab-shell-check/main.go:44:23: Error return value of `logCloser.Close` is not checked (errcheck)
cmd/gitlab-shell-check/main.go:48:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
cmd/gitlab-shell-check/main.go:49:3: exitAfterDefer: os.Exit will exit, and `defer logCloser.Close()` will not run (gocritic)
cmd/gitlab-shell-check/main.go:55:5: ineffectual assignment to ctx (ineffassign)
cmd/gitlab-shell-check/main.go:56:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
cmd/gitlab-shell/command/command.go:74: cmd/gitlab-shell/command/command.go:74: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: When 1.21+ only Golang is support..." (godox)
cmd/gitlab-shell/main.go:1:1: package-comments: should have a package comment (revive)
cmd/gitlab-shell/main.go:42:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
cmd/gitlab-shell/main.go:48:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
cmd/gitlab-shell/main.go:53:23: Error return value of `logCloser.Close` is not checked (errcheck)
cmd/gitlab-shell/main.go:60:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
cmd/gitlab-shell/main.go:61:3: exitAfterDefer: os.Exit will exit, and `defer logCloser.Close()` will not run (gocritic)
cmd/gitlab-sshd/acceptance_test.go:115:6: go-require: do not use require in http handlers (testifylint)
cmd/gitlab-sshd/acceptance_test.go:125:5: go-require: do not use require in http handlers (testifylint)
cmd/gitlab-sshd/acceptance_test.go:132:5: go-require: do not use require in http handlers (testifylint)
cmd/gitlab-sshd/acceptance_test.go:135:5: go-require: do not use require in http handlers (testifylint)
cmd/gitlab-sshd/acceptance_test.go:188:4: go-require: do not use require in http handlers (testifylint)
cmd/gitlab-sshd/acceptance_test.go:498:4: go-require: do not use require in http handlers (testifylint)
cmd/gitlab-sshd/main.go:1:1: package-comments: should have a package comment (revive)
cmd/gitlab-sshd/main.go:30:5: var-naming: var gitlabUrl should be gitlabURL (revive)
cmd/gitlab-sshd/main.go:44: Function 'main' is too long (73 > 60) (funlen)
cmd/gitlab-sshd/main.go:70:23: Error return value of `logCloser.Close` is not checked (errcheck)
cmd/gitlab-sshd/main.go:108:18: Error return value of `server.Shutdown` is not checked (errcheck)
internal/command/authorizedkeys/authorized_keys.go:1:1: package-comments: should have a package comment (revive)
internal/command/authorizedkeys/authorized_keys.go:15:6: exported: exported type Command should have comment or be unexported (revive)
internal/command/authorizedkeys/authorized_keys.go:21:1: exported: exported method Command.Execute should have comment or be unexported (revive)
internal/command/authorizedkeys/authorized_keys.go:26: internal/command/authorizedkeys/authorized_keys.go:26: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "TODO: Log this event once we have a cons..." (godox)
internal/command/authorizedkeys/authorized_keys.go:41:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
internal/command/authorizedkeys/authorized_keys.go:50:14: Error return value of `fmt.Fprintln` is not checked (errcheck)
internal/command/authorizedprincipals/authorized_principals.go:1:1: package-comments: should have a package comment (revive)
internal/command/authorizedprincipals/authorized_principals.go:13:6: exported: exported type Command should have comment or be unexported (revive)
internal/command/authorizedprincipals/authorized_principals.go:19:1: exported: exported method Command.Execute should have comment or be unexported (revive)
internal/command/authorizedprincipals/authorized_principals.go:45:14: Error return value of `fmt.Fprintln` is not checked (errcheck)
internal/command/command.go:1:1: package-comments: should have a package comment (revive)
internal/command/command.go:15:6: exported: exported type Command should have comment or be unexported (revive)
internal/command/command.go:19:6: exported: exported type LogMetadata should have comment or be unexported (revive)
internal/command/command.go:26:6: exported: exported type LogData should have comment or be unexported (revive)
internal/command/command.go:32:1: exported: exported function CheckForVersionFlag should have comment or be unexported (revive)
internal/command/command.go:43:1: exported: comment on exported function Setup should be of the form "Setup ..." (revive)
internal/command/command.go:75:15: Error return value of `closer.Close` is not checked (errcheck)
internal/command/command.go:79:1: exported: exported function NewLogData should have comment or be unexported (revive)
internal/command/commandargs/authorized_keys.go:1:1: package-comments: should have a package comment (revive)
internal/command/commandargs/authorized_keys.go:8:6: exported: exported type AuthorizedKeys should have comment or be unexported (revive)
internal/command/commandargs/authorized_keys.go:15:1: exported: exported method AuthorizedKeys.Parse should have comment or be unexported (revive)
internal/command/commandargs/authorized_keys.go:27:1: exported: exported method AuthorizedKeys.GetArguments should have comment or be unexported (revive)
internal/command/commandargs/authorized_keys.go:35:10: errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive)
internal/command/commandargs/authorized_principals.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/command/commandargs/authorized_principals.go:8:6: exported: exported type AuthorizedPrincipals should have comment or be unexported (revive)
internal/command/commandargs/authorized_principals.go:10:2: var-naming: struct field KeyId should be KeyID (revive)
internal/command/commandargs/authorized_principals.go:14:1: exported: exported method AuthorizedPrincipals.Parse should have comment or be unexported (revive)
internal/command/commandargs/authorized_principals.go:25:1: exported: exported method AuthorizedPrincipals.GetArguments should have comment or be unexported (revive)
internal/command/commandargs/authorized_principals.go:33:10: errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive)
internal/command/commandargs/authorized_principals.go:36:2: var-naming: var keyId should be keyID (revive)
internal/command/commandargs/command_args.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/command/commandargs/command_args.go:3:6: exported: exported type CommandType should have comment or be unexported (revive)
internal/command/commandargs/command_args.go:5:6: exported: exported type CommandArgs should have comment or be unexported (revive)
internal/command/commandargs/shell.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/command/commandargs/shell.go:13:2: exported: exported const Discover should have comment (or a comment on this block) or be unexported (revive)
internal/command/commandargs/shell.go:28:2: exported: exported var GitCommands should have comment or be unexported (revive)
internal/command/commandargs/shell.go:31:6: exported: exported type Shell should have comment or be unexported (revive)
internal/command/commandargs/shell.go:34:2: var-naming: struct field GitlabKeyId should be GitlabKeyID (revive)
internal/command/commandargs/shell.go:36:2: var-naming: struct field SshArgs should be SSHArgs (revive)
internal/command/commandargs/shell.go:41:1: exported: exported method Shell.Parse should have comment or be unexported (revive)
internal/command/commandargs/shell.go:51:1: exported: exported method Shell.GetArguments should have comment or be unexported (revive)
internal/command/commandargs/shell.go:57:10: ST1005: error strings should not be capitalized (stylecheck)
internal/command/commandargs/shell.go:61:10: ST1005: error strings should not be capitalized (stylecheck)
internal/command/commandargs/shell.go:69:6: var-naming: var keyId should be keyID (revive)
internal/command/commandargs/shell.go:98:6: var-naming: func tryParseKeyId should be tryParseKeyID (revive)
internal/command/commandargs/shell.go:106:1: exported: exported method Shell.ParseCommand should have comment or be unexported (revive)
internal/command/discover/discover.go:1:1: package-comments: should have a package comment (revive)
internal/command/discover/discover.go:14:6: exported: exported type Command should have comment or be unexported (revive)
internal/command/discover/discover.go:20:1: exported: exported method Command.Execute should have comment or be unexported (revive)
internal/command/discover/discover.go:23:15: ST1005: error strings should not be capitalized (stylecheck)
internal/command/discover/discover.go:29:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
internal/command/discover/discover.go:32:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
internal/command/discover/discover.go:35:20: context-keys-type: should not use basic type string as key in context.WithValue (revive)
internal/command/gitauditevent/audit.go:1:1: package-comments: should have a package comment (revive)
internal/command/gitauditevent/audit_test.go:33:5: go-require: do not use require in http handlers (testifylint)
internal/command/gitauditevent/audit_test.go:37:5: go-require: do not use require in http handlers (testifylint)
internal/command/gitauditevent/audit_test.go:38:5: go-require: do not use require in http handlers (testifylint)
internal/command/gitauditevent/audit_test.go:39:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/pull.go:1:1: package-comments: should have a package comment (revive)
internal/command/githttp/pull.go:20:5: var-naming: var uploadPackHttpPrefix should be uploadPackHTTPPrefix (revive)
internal/command/githttp/pull.go:22:6: exported: exported type PullCommand should have comment or be unexported (revive)
internal/command/githttp/pull.go:39:1: exported: exported method PullCommand.Execute should have comment or be unexported (revive)
internal/command/githttp/pull.go:58: 58-76 lines are duplicate of `internal/command/githttp/push.go:57-75` (dupl)
internal/command/githttp/pull.go:63:27: Error return value of `response.Body.Close` is not checked (errcheck)
internal/command/githttp/pull.go:70:10: ST1005: error strings should not be capitalized (stylecheck)
internal/command/githttp/pull.go:83:27: Error return value of `response.Body.Close` is not checked (errcheck)
internal/command/githttp/pull.go:98:27: Error return value of `response.Body.Close` is not checked (errcheck)
internal/command/githttp/pull.go:111:11: Error return value of `pw.Write` is not checked (errcheck)
internal/command/githttp/pull.go:118:12: Error return value of `pw.Write` is not checked (errcheck)
internal/command/githttp/pull.go:124:10: Error return value of `pw.Close` is not checked (errcheck)
internal/command/githttp/pull_test.go:117:7: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/pull_test.go:170:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/pull_test.go:179:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/pull_test.go:182:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/pull_test.go:198:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/pull_test.go:201:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/pull_test.go:202:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/pull_test.go:203:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/push.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/command/githttp/push.go:20:5: var-naming: var receivePackHttpPrefix should be receivePackHTTPPrefix (revive)
internal/command/githttp/push.go:22:6: exported: exported type PushCommand should have comment or be unexported (revive)
internal/command/githttp/push.go:29:1: exported: comment on exported method PushCommand.Execute should be of the form "Execute ..." (revive)
internal/command/githttp/push.go:57: 57-75 lines are duplicate of `internal/command/githttp/pull.go:58-76` (dupl)
internal/command/githttp/push.go:62:27: Error return value of `response.Body.Close` is not checked (errcheck)
internal/command/githttp/push.go:69:10: ST1005: error strings should not be capitalized (stylecheck)
internal/command/githttp/push.go:82:27: Error return value of `response.Body.Close` is not checked (errcheck)
internal/command/githttp/push.go:97:27: Error return value of `response.Body.Close` is not checked (errcheck)
internal/command/githttp/push.go:110:11: Error return value of `pw.Write` is not checked (errcheck)
internal/command/githttp/push.go:122:10: Error return value of `io.Copy` is not checked (errcheck)
internal/command/githttp/push.go:125:10: Error return value of `pw.Close` is not checked (errcheck)
internal/command/githttp/push_test.go:76:7: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/push_test.go:167:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/push_test.go:176:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/push_test.go:179:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/push_test.go:194:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/push_test.go:197:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/push_test.go:198:5: go-require: do not use require in http handlers (testifylint)
internal/command/githttp/push_test.go:199:5: go-require: do not use require in http handlers (testifylint)
internal/command/healthcheck/healthcheck.go:1:1: package-comments: should have a package comment (revive)
internal/command/healthcheck/healthcheck.go:17:6: exported: exported type Command should have comment or be unexported (revive)
internal/command/healthcheck/healthcheck.go:22:1: exported: exported method Command.Execute should have comment or be unexported (revive)
internal/command/healthcheck/healthcheck.go:28:13: Error return value of `fmt.Fprintf` is not checked (errcheck)
internal/command/healthcheck/healthcheck.go:34:13: Error return value of `fmt.Fprintf` is not checked (errcheck)
internal/command/healthcheck/healthcheck_test.go:37:41: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
internal/command/lfsauthenticate/lfsauthenticate.go:87:13: Error return value of `fmt.Fprintf` is not checked (errcheck)
internal/command/lfsauthenticate/lfsauthenticate_test.go:76:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfsauthenticate/lfsauthenticate_test.go:79:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfsauthenticate/lfsauthenticate_test.go:80:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfsauthenticate/lfsauthenticate_test.go:89:6: go-require: do not use require in http handlers (testifylint)
internal/command/lfsauthenticate/lfsauthenticate_test.go:100:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfsauthenticate/lfsauthenticate_test.go:103:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfsauthenticate/lfsauthenticate_test.go:122:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/gitlab_backend.go:40:6: exported: exported type GitlabAuthentication should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:45:6: exported: exported type GitlabBackend should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:60:1: exported: exported function NewGitlabBackend should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:104:1: exported: exported method GitlabBackend.Batch should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:215:1: exported: exported method GitlabBackend.Upload should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:224:1: exported: exported method GitlabBackend.Verify should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:229:1: exported: exported method GitlabBackend.Download should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:237:1: exported: exported method GitlabBackend.LockBackend should have comment or be unexported (revive)
internal/command/lfstransfer/lfstransfer.go:26:6: exported: exported type Command should have comment or be unexported (revive)
internal/command/lfstransfer/lfstransfer.go:32: Function 'Execute' is too long (63 > 60) (funlen)
internal/command/lfstransfer/lfstransfer.go:52:20: context-keys-type: should not use basic type string as key in context.WithValue (revive)
internal/command/lfstransfer/lfstransfer.go:114:9: composites: gitlab.com/gitlab-org/gitlab-shell/v14/internal/command/shared/accessverifier.Command struct literal uses unkeyed fields (govet)
internal/command/lfstransfer/lfstransfer_test.go:19:2: import 'github.com/git-lfs/pktline' is not allowed from list 'test' (depguard)
internal/command/lfstransfer/lfstransfer_test.go:49:3: go-require: require must only be used in the goroutine running the test function (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:277:2: declaration has 3 blank identifiers (dogsled)
internal/command/lfstransfer/lfstransfer_test.go:1113:1: cognitive complexity 33 of func `setup` is high (> 20) (gocognit)
internal/command/lfstransfer/lfstransfer_test.go:1162:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1170:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1173:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1181:6: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1190:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1217:7: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1250:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1256:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1263:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1264:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1266:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1272:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1280:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1297:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1312:7: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1316:6: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1356:7: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1382:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1384:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1385:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1409:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1411:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1412:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1433:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1435:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1436:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1451:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1453:5: go-require: do not use require in http handlers (testifylint)
internal/command/lfstransfer/lfstransfer_test.go:1454:5: go-require: do not use require in http handlers (testifylint)
internal/command/personalaccesstoken/personalaccesstoken.go:1:1: package-comments: should have a package comment (revive)
internal/command/personalaccesstoken/personalaccesstoken.go:25:6: exported: exported type Command should have comment or be unexported (revive)
internal/command/personalaccesstoken/personalaccesstoken.go:38:1: exported: exported method Command.Execute should have comment or be unexported (revive)
internal/command/personalaccesstoken/personalaccesstoken.go:53:12: Error return value of `fmt.Fprint` is not checked (errcheck)
internal/command/personalaccesstoken/personalaccesstoken.go:54:12: Error return value of `fmt.Fprint` is not checked (errcheck)
internal/command/personalaccesstoken/personalaccesstoken.go:55:12: Error return value of `fmt.Fprint` is not checked (errcheck)
internal/command/personalaccesstoken/personalaccesstoken.go:62:10: ST1005: error strings should not be capitalized (stylecheck)
internal/command/personalaccesstoken/personalaccesstoken.go:89:10: ST1005: error strings should not be capitalized (stylecheck)
internal/command/personalaccesstoken/personalaccesstoken_test.go:31:5: go-require: do not use require in http handlers (testifylint)
internal/command/personalaccesstoken/personalaccesstoken_test.go:180:62: `reposotory` is a misspelling of `repository` (misspell)
internal/command/personalaccesstoken/personalaccesstoken_test.go:194:63: `reposotory` is a misspelling of `repository` (misspell)
internal/command/personalaccesstoken/personalaccesstoken_test.go:202:74: `reposotory` is a misspelling of `repository` (misspell)
internal/command/personalaccesstoken/personalaccesstoken_test.go:205:54: `reposotory` is a misspelling of `repository` (misspell)
internal/command/readwriter/readwriter.go:1:1: package-comments: should have a package comment (revive)
internal/command/readwriter/readwriter.go:7:6: exported: exported type ReadWriter should have comment or be unexported (revive)
internal/command/receivepack/gitalycall_test.go:24:4: S1038: should use t.Logf(...) instead of t.Log(fmt.Sprintf(...)) (gosimple)
internal/command/receivepack/gitalycall_test.go:31:5: var-naming: struct field keyId should be keyID (revive)
internal/command/receivepack/gitalycall_test.go:98:5: expected-actual: need to reverse actual and expected values (testifylint)
internal/command/shared/accessverifier/accessverifier.go:1:1: package-comments: should have a package comment (revive)
internal/command/shared/accessverifier/accessverifier.go:14:6: exported: exported type Response should have comment or be unexported (revive)
internal/command/shared/accessverifier/accessverifier.go:16:6: exported: exported type Command should have comment or be unexported (revive)
internal/command/shared/accessverifier/accessverifier.go:22:1: exported: exported method Command.Verify should have comment or be unexported (revive)
internal/command/shared/accessverifier/accessverifier_test.go:31:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/accessverifier/accessverifier_test.go:35:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/accessverifier/accessverifier_test.go:41:6: go-require: do not use require in http handlers (testifylint)
internal/command/shared/accessverifier/accessverifier_test.go:47:6: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:27:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:30:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:32:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:33:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:36:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:43:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:46:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:48:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:49:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:52:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:96:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:99:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:101:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:102:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:105:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:112:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:115:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:117:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:118:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/customaction/customaction_test.go:121:5: go-require: do not use require in http handlers (testifylint)
internal/command/shared/disallowedcommand/disallowedcommand.go:1:1: package-comments: should have a package comment (revive)
internal/command/shared/disallowedcommand/disallowedcommand.go:6:2: exported: exported var Error should have comment or be unexported (revive)
internal/command/twofactorrecover/twofactorrecover.go:37:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
internal/command/twofactorrecover/twofactorrecover.go:47:14: Error return value of `fmt.Fprintln` is not checked (errcheck)
internal/command/twofactorrecover/twofactorrecover.go:70:13: Error return value of `fmt.Fprint` is not checked (errcheck)
internal/command/twofactorrecover/twofactorrecover.go:73:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
internal/command/twofactorrecover/twofactorrecover_test.go:31:5: go-require: do not use require in http handlers (testifylint)
internal/command/twofactorverify/twofactorverify.go:40:12: Error return value of `fmt.Fprint` is not checked (errcheck)
internal/command/twofactorverify/twofactorverify.go:71:13: Error return value of `fmt.Fprintf` is not checked (errcheck)
internal/command/twofactorverify/twofactorverify_test.go:38:5: go-require: do not use require in http handlers (testifylint)
internal/command/twofactorverify/twofactorverify_test.go:41:5: go-require: do not use require in http handlers (testifylint)
internal/command/twofactorverify/twofactorverify_test.go:56:6: go-require: do not use require in http handlers (testifylint)
internal/command/twofactorverify/twofactorverify_test.go:68:5: go-require: do not use require in http handlers (testifylint)
internal/command/twofactorverify/twofactorverify_test.go:71:5: go-require: do not use require in http handlers (testifylint)
internal/command/uploadarchive/gitalycall_test.go:24:4: S1038: should use t.Logf(...) instead of t.Log(fmt.Sprintf(...)) (gosimple)
internal/command/uploadarchive/gitalycall_test.go:32:4: var-naming: var userId should be userID (revive)
internal/config/config.go:1:1: package-comments: should have a package comment (revive)
internal/config/config.go:21:2: G101: Potential hardcoded credentials (gosec)
internal/config/config.go:24:6: exported: exported type YamlDuration should have comment or be unexported (revive)
internal/config/config.go:26:6: exported: exported type GSSAPIConfig should have comment or be unexported (revive)
internal/config/config.go:33:6: exported: exported type ServerConfig should have comment or be unexported (revive)
internal/config/config.go:55:6: exported: exported type HttpSettingsConfig should have comment or be unexported (revive)
internal/config/config.go:63:6: exported: exported type LFSConfig should have comment or be unexported (revive)
internal/config/config.go:67:6: exported: exported type PATConfig should have comment or be unexported (revive)
internal/config/config.go:72:6: exported: exported type Config should have comment or be unexported (revive)
internal/config/config.go:78:2: var-naming: struct field GitlabUrl should be GitlabURL (revive)
internal/config/config.go:85:2: var-naming: struct field HttpSettings should be HTTPSettings (revive)
internal/config/config.go:130:1: exported: exported method YamlDuration.UnmarshalYAML should have comment or be unexported (revive)
internal/config/config.go:141:1: exported: exported method Config.ApplyGlobalState should have comment or be unexported (revive)
internal/config/config.go:143:12: Error return value of `os.Setenv` is not checked (errcheck)
internal/config/config.go:147:1: exported: exported method Config.HTTPClient should have comment or be unexported (revive)
internal/config/config.go:194:9: copylocks: assignment copies lock value to *cfg: gitlab.com/gitlab-org/gitlab-shell/v14/internal/config.Config contains sync.Once contains sync/atomic.Uint32 contains sync/atomic.noCopy (govet)
internal/config/config.go:197:22: G304: Potential file inclusion via variable (gosec)
internal/config/config.go:208:3: var-naming: var unescapedUrl should be unescapedURL (revive)
internal/config/config.go:254:1: receiver-naming: receiver name cfg should be consistent with previous receiver name c for Config (revive)
internal/console/console.go:39:13: Error return value of `fmt.Fprint` is not checked (errcheck)
internal/console/console.go:65:13: Error return value of `fmt.Fprint` is not checked (errcheck)
internal/console/console.go:67:13: Error return value of `fmt.Fprint` is not checked (errcheck)
internal/executable/executable.go:1:1: package-comments: should have a package comment (revive)
internal/executable/executable.go:9:2: exported: exported const BinDir should have comment (or a comment on this block) or be unexported (revive)
internal/executable/executable.go:16:6: exported: exported type Executable should have comment or be unexported (revive)
internal/executable/executable.go:26:1: exported: exported function New should have comment or be unexported (revive)
internal/executable/executable_test.go:64:4: expected-actual: need to reverse actual and expected values (testifylint)
internal/executable/executable_test.go:65:4: expected-actual: need to reverse actual and expected values (testifylint)
internal/gitaly/gitaly.go:1:1: package-comments: should have a package comment (revive)
internal/gitaly/gitaly.go:12:2: ST1019: package "gitlab.com/gitlab-org/gitaly/v16/client" is being imported more than once (stylecheck)
internal/gitaly/gitaly.go:13:2: ST1019(related information): other import of "gitlab.com/gitlab-org/gitaly/v16/client" (stylecheck)
internal/gitaly/gitaly.go:22:6: exported: exported type Command should have comment or be unexported (revive)
internal/gitaly/gitaly.go:34:6: exported: exported type Client should have comment or be unexported (revive)
internal/gitaly/gitaly.go:40:1: exported: exported method Client.InitSidechannelRegistry should have comment or be unexported (revive)
internal/gitaly/gitaly.go:44:1: exported: exported method Client.GetConnection should have comment or be unexported (revive)
internal/gitaly/gitaly.go:56:5: shadow: declaration of "conn" shadows declaration at line 46 (govet)
internal/gitlabnet/accessverifier/client_test.go:261:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/accessverifier/client_test.go:264:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/accessverifier/client_test.go:269:6: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/accessverifier/client_test.go:270:6: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/accessverifier/client_test.go:274:6: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/accessverifier/client_test.go:275:6: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/accessverifier/client_test.go:279:6: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/accessverifier/client_test.go:280:6: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/accessverifier/client_test.go:301:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/accessverifier/client_test.go:305:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/client.go:1:1: package-comments: should have a package comment (revive)
internal/gitlabnet/client.go:15:2: error-naming: error var ParsingError should have name of the form ErrFoo (revive)
internal/gitlabnet/client.go:18:1: exported: exported function GetClient should have comment or be unexported (revive)
internal/gitlabnet/client.go:25:15: ST1005: error strings should not be capitalized (stylecheck)
internal/gitlabnet/client.go:31:1: exported: exported function ParseJSON should have comment or be unexported (revive)
internal/gitlabnet/client.go:39:1: exported: exported function ParseIP should have comment or be unexported (revive)
internal/gitlabnet/git/client_test.go:56:14: string `0032want 0a53e9ddeaddad63ad106860237bbf53411d11a7
` has 3 occurrences, make it a constant (goconst)
internal/gitlabnet/git/client_test.go:160:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:161:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:169:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:170:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:171:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:172:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:175:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:185:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:186:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:187:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:188:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:191:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:200:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:201:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:204:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:213:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:214:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/git/client_test.go:217:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/gitauditevent/client.go:1:1: package-comments: should have a package comment (revive)
internal/gitlabnet/gitauditevent/client.go:16:6: exported: exported type Client should have comment or be unexported (revive)
internal/gitlabnet/gitauditevent/client.go:21:1: exported: exported function NewClient should have comment or be unexported (revive)
internal/gitlabnet/gitauditevent/client.go:30:6: exported: exported type Request should have comment or be unexported (revive)
internal/gitlabnet/gitauditevent/client.go:38:1: exported: exported method Client.Audit should have comment or be unexported (revive)
internal/gitlabnet/gitauditevent/client.go:51:27: Error return value of `response.Body.Close` is not checked (errcheck)
internal/gitlabnet/gitauditevent/client_test.go:51:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/gitauditevent/client_test.go:55:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/gitauditevent/client_test.go:56:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/gitauditevent/client_test.go:57:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/gitauditevent/client_test.go:58:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/gitauditevent/client_test.go:59:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/gitauditevent/client_test.go:60:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/gitauditevent/client_test.go:61:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/healthcheck/client_test.go:19:41: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
internal/gitlabnet/lfsauthenticate/client_test.go:29:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/lfsauthenticate/client_test.go:32:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/lfsauthenticate/client_test.go:42:6: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/lfstransfer/client.go:1:1: package-comments: should have a package comment (revive)
internal/gitlabnet/lfstransfer/client.go:20:6: exported: exported type Client should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:28:6: exported: exported type BatchAction should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:35:6: exported: exported type BatchObject should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:53:6: exported: exported type BatchResponse should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:82:6: exported: exported type LockOwner should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:86:6: exported: exported type Lock should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:93:6: exported: exported type ListLocksResponse should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:98:6: exported: exported type ListLocksVerifyResponse should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:104:5: exported: exported var ClientHeader should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:106:1: exported: exported function NewClient should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:124:1: exported: exported method Client.Batch should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:125: internal/gitlabnet/lfstransfer/client.go:125: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: This causes tests to fail" (godox)
internal/gitlabnet/lfstransfer/client.go:171:1: exported: exported method Client.GetObject should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:191:1: exported: exported method Client.PutObject should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:212:1: exported: exported method Client.Lock should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:269:1: exported: exported method Client.Unlock should have comment or be unexported (revive)
internal/gitlabnet/lfstransfer/client.go:319:1: exported: exported method Client.ListLocksVerify should have comment or be unexported (revive)
internal/gitlabnet/personalaccesstoken/client_test.go:30:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/twofactorrecover/client_test.go:30:5: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/twofactorverify/client_test.go:24:3: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/twofactorverify/client_test.go:27:3: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/twofactorverify/client_test.go:34:4: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/twofactorverify/client_test.go:40:4: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/twofactorverify/client_test.go:46:4: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/twofactorverify/client_test.go:57:4: go-require: do not use require in http handlers (testifylint)
internal/gitlabnet/twofactorverify/client_test.go:78:5: go-require: do not use require in http handlers (testifylint)
internal/logger/logger.go:1:1: package-comments: should have a package comment (revive)
internal/logger/logger.go:55:9: ST1005: error strings should not be capitalized (stylecheck)
internal/logger/logger.go:69:27: printf: non-constant format string in call to fmt.Fprintf (govet)
internal/metrics/metrics.go:1:1: package-comments: should have a package comment (revive)
internal/metrics/metrics.go:37:2: exported: exported var SshdSessionDuration should have comment or be unexported (revive)
internal/metrics/metrics.go:165:1: exported: exported function NewRoundTripper should have comment or be unexported (revive)
internal/pktline/pktline.go:1:1: package-comments: should have a package comment (revive)
internal/pktline/pktline.go:30:1: exported: exported function IsRefRemoval should have comment or be unexported (revive)
internal/sshd/gssapi_unsupported.go:11:1: exported: exported function NewGSSAPIServer should have comment or be unexported (revive)
internal/sshd/gssapi_unsupported.go:19:6: exported: exported type OSGSSAPIServer should have comment or be unexported (revive)
internal/sshd/gssapi_unsupported.go:23:1: exported: exported method OSGSSAPIServer.AcceptSecContext should have comment or be unexported (revive)
internal/sshd/gssapi_unsupported.go:27:1: exported: exported method OSGSSAPIServer.VerifyMIC should have comment or be unexported (revive)
internal/sshd/gssapi_unsupported.go:31:1: exported: exported method OSGSSAPIServer.DeleteSecContext should have comment or be unexported (revive)
internal/sshd/server_config_test.go:5:2: SA1019: "crypto/dsa" has been deprecated since Go 1.16 because it shouldn't be used: DSA is a legacy algorithm, and modern alternatives such as Ed25519 (implemented by package crypto/ed25519) should be used instead. Keys with 1024-bit moduli (L1024N160 parameters) are cryptographically weak, while bigger keys are not widely supported. Note that FIPS 186-5 no longer approves DSA for signature generation. (staticcheck)
internal/sshd/server_config_test.go:63:2: declaration has 3 blank identifiers (dogsled)
internal/sshd/sshd.go:268:6: func `extractDataFromContext` is unused (unused)
internal/sshd/sshd_test.go:412:5: go-require: do not use require in http handlers (testifylint)
internal/sshd/sshd_test.go:413:5: go-require: do not use require in http handlers (testifylint)
internal/sshd/sshd_test.go:420:5: go-require: do not use require in http handlers (testifylint)
internal/sshd/sshd_test.go:421:5: go-require: do not use require in http handlers (testifylint)
internal/testhelper/requesthandlers/requesthandlers.go:25:5: go-require: do not use require in http handlers (testifylint)
internal/testhelper/requesthandlers/requesthandlers.go:63:5: go-require: do not use require in http handlers (testifylint)
internal/testhelper/requesthandlers/requesthandlers.go:90:5: go-require: do not use require in http handlers (testifylint)
internal/testhelper/requesthandlers/requesthandlers.go:97:5: go-require: do not use require in http handlers (testifylint)
internal/testhelper/requesthandlers/requesthandlers.go:104:5: go-require: do not use require in http handlers (testifylint)
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.