Call support/lint.sh when running make lint

Makefile

@@ -86,13 +86,15 @@ coverage: coverage_golang
 coverage_golang:
 	[ -f cover.out ] && go tool cover -func cover.out
 
-lint: ${GOLANGCI_LINT_FILE}
-	${GOLANGCI_LINT_FILE} --version
-	${GOLANGCI_LINT_FILE} run --issues-exit-code 0 --print-issued-lines=false ${GOLANGCI_LINT_ARGS}
+lint:
+	@support/lint.sh ./...
+
+golangci: ${GOLANGCI_LINT_FILE}
+	@${GOLANGCI_LINT_FILE} run --issues-exit-code 0 --print-issued-lines=false ${GOLANGCI_LINT_ARGS}
 
 ${GOLANGCI_LINT_FILE}:
-	mkdir -p $(shell dirname ${GOLANGCI_LINT_FILE})
-	curl -L https://github.com/golangci/golangci-lint/releases/download/v${GOLANGCI_LINT_VERSION}/golangci-lint-${GOLANGCI_LINT_VERSION}-${OS}-${ARCH}.tar.gz | tar --strip-components 1 -zOxf - golangci-lint-${GOLANGCI_LINT_VERSION}-${OS}-${ARCH}/golangci-lint > ${GOLANGCI_LINT_FILE} && chmod +x ${GOLANGCI_LINT_FILE}
+	@mkdir -p $(shell dirname ${GOLANGCI_LINT_FILE})
+	@curl -L https://github.com/golangci/golangci-lint/releases/download/v${GOLANGCI_LINT_VERSION}/golangci-lint-${GOLANGCI_LINT_VERSION}-${OS}-${ARCH}.tar.gz | tar --strip-components 1 -zOxf - golangci-lint-${GOLANGCI_LINT_VERSION}-${OS}-${ARCH}/golangci-lint > ${GOLANGCI_LINT_FILE} && chmod +x ${GOLANGCI_LINT_FILE}
 
 setup: make_necessary_dirs bin/gitlab-shell
 

support/lint.sh

+#!/bin/bash
+
+# Unfortunately, gitlab-shell fails many lint checks which we currently ignore
+#
+LINT_KNOWN_ACCEPTABLE_FILE="support/lint_last_known_acceptable.txt"
+LINT_KNOWN_ACCEPTABLE="$(cat ${LINT_KNOWN_ACCEPTABLE_FILE})"
+
+LINT_RESULT_FILE=$(mktemp /tmp/lint_result.XXXXXX)
+LINT_RESULT=$(make --no-print-directory golangci | tee "${LINT_RESULT_FILE}")
+
+if [[ "${LINT_RESULT}x" == "${LINT_KNOWN_ACCEPTABLE}x" ]]; then
+  exit 0
+else
+  echo
+
+  diff -u "${LINT_KNOWN_ACCEPTABLE_FILE}" "${LINT_RESULT_FILE}"
+
+  echo
+  echo "INFO: The above diff could be caused by a lint error being fixed _or_ newly added."
+  echo "      If you believe the diff is as a result of a lint error being fixed, please run"
+  echo "      the following and try re-running 'make lint' again:"
+  echo
+  echo "    make golangci > ${LINT_KNOWN_ACCEPTABLE_FILE}"
+  echo
+  echo "INFO: Take specific note of the go version used as the diffs can vary."
+  echo
+
+  exit 1
+fi