As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
Commit ac9fee4d authored by Patrick Bajao's avatar Patrick Bajao
Browse files

Merge branch 'sh-log-content-length-bytes' into 'master'

Log Content-Length bytes in API response

See merge request gitlab-org/gitlab-shell!427
parents dc7d87e8 6b05bee1
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -94,6 +94,7 @@ func testSuccessfulGet(t *testing.T, client *GitlabNetClient) {
require.Equal(t, logrus.InfoLevel, entries[0].Level)
require.Contains(t, entries[0].Message, "method=GET")
require.Contains(t, entries[0].Message, "status=200")
require.Contains(t, entries[0].Message, "content_length_bytes=")
require.Contains(t, entries[0].Message, "Finished HTTP request")
require.Contains(t, entries[0].Message, "correlation_id=")
})
Loading
Loading
@@ -120,6 +121,7 @@ func testSuccessfulPost(t *testing.T, client *GitlabNetClient) {
require.Equal(t, logrus.InfoLevel, entries[0].Level)
require.Contains(t, entries[0].Message, "method=POST")
require.Contains(t, entries[0].Message, "status=200")
require.Contains(t, entries[0].Message, "content_length_bytes=")
require.Contains(t, entries[0].Message, "Finished HTTP request")
require.Contains(t, entries[0].Message, "correlation_id=")
})
Loading
Loading
Loading
Loading
@@ -156,6 +156,10 @@ func (c *GitlabNetClient) DoRequest(ctx context.Context, method, path string, da
return nil, err
}
if response.ContentLength >= 0 {
logger = logger.WithField("content_length_bytes", response.ContentLength)
}
logger.Info("Finished HTTP request")
return response, nil
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment