As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
Unverified Commit b7106f34 authored by Ash McKenzie's avatar Ash McKenzie
Browse files

Add note about asserting Shutdown() doesn't error

parent eede646c
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
internal/sshd/sshd_test.go
+ 1
− 0
View file @ b7106f34
@@ -433,6 +433,7 @@ func setupServerWithContext(t *testing.T, cfg *config.Config, ctx context.Contex
require.NoError(t, err)
go func() { require.NoError(t, s.ListenAndServe(ctx)) }()
// NOTE: Changing the below to { require.NoError(t, s.Shutdown()) } results in failed tests
t.Cleanup(func() { s.Shutdown() })
verifyStatus(t, s, StatusReady)
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.