Merge branch '765-lint-connection' into 'main'

Added inspecting result in connection

Closes #765

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/1136



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Gavin Hinfey <ghinfey@gitlab.com>
Approved-by: Javiera Tapia <jtapia@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Archish <archishthakkar@gmail.com>

internal/sshd/connection.go

@@ -168,7 +168,15 @@ func (c *connection) sendKeepAliveMsg(ctx context.Context, sconn *ssh.ServerConn
 		case <-ticker.C:
 			ctxlog.Debug("connection: sendKeepAliveMsg: send keepalive message to a client")
 
-			_, _, _ = sconn.SendRequest(KeepAliveMsg, true, nil)
+			status, payload, err := sconn.SendRequest(KeepAliveMsg, true, nil)
+			if err != nil {
+				ctxlog.Errorf("Error occurred while sending request :%v", err)
+				return
+			}
+
+			if status {
+				ctxlog.Debugf("connection: sendKeepAliveMsg: payload: %v", string(payload))
+			}
 		}
 	}
 }

internal/sshd/connection_test.go

@@ -78,7 +78,7 @@ func (f *fakeConn) SendRequest(name string, _ bool, _ []byte) (bool, []byte, err
 
 	f.sentRequestName = name
 
-	return true, nil, nil
+	return true, []byte("I am a response"), nil
 }
 
 func setup(newChannel *fakeNewChannel) (*connection, chan ssh.NewChannel) {