Rename Http to HTTP and comment

internal/sshd/sshd_test.go

@@ -425,7 +425,7 @@ func setupServerWithContext(ctx context.Context, t *testing.T, cfg *config.Confi
 		},
 	}
 
-	url := testserver.StartSocketHttpServer(t, requests)
+	url := testserver.StartSocketHTTPServer(t, requests)
 
 	if cfg == nil {
 		cfg = &config.Config{}

support/lint_last_known_acceptable.txt

@@ -35,13 +35,9 @@ client/testserver/gitalyserver.go:82:1: exported: exported function StartGitalyS
 client/testserver/gitalyserver.go:131:3: go-require: require must only be used in the goroutine running the test function (testifylint)
 client/testserver/testserver.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
 client/testserver/testserver.go:20:6: exported: exported type TestRequestHandler should have comment or be unexported (revive)
-client/testserver/testserver.go:25:1: exported: exported function StartSocketHttpServer should have comment or be unexported (revive)
-client/testserver/testserver.go:45:12: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
-client/testserver/testserver.go:51:17: Error return value of `server.Serve` is not checked (errcheck)
-client/testserver/testserver.go:58:1: exported: exported function StartHttpServer should have comment or be unexported (revive)
-client/testserver/testserver.go:67:1: exported: exported function StartRetryHttpServer should have comment or be unexported (revive)
-client/testserver/testserver.go:95:1: exported: exported function StartHttpsServer should have comment or be unexported (revive)
-client/testserver/testserver.go:113:18: G304: Potential file inclusion via variable (gosec)
+client/testserver/testserver.go:46:12: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
+client/testserver/testserver.go:52:17: Error return value of `server.Serve` is not checked (errcheck)
+client/testserver/testserver.go:117:18: G304: Potential file inclusion via variable (gosec)
 client/transport.go:58:1: exported: exported function DefaultTransport should have comment or be unexported (revive)
 client/transport.go:62:1: exported: exported function NewTransport should have comment or be unexported (revive)
 cmd/gitlab-shell-authorized-keys-check/main.go:40:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
@@ -306,20 +302,17 @@ internal/config/config.go:21:2: G101: Potential hardcoded credentials (gosec)
 internal/config/config.go:24:6: exported: exported type YamlDuration should have comment or be unexported (revive)
 internal/config/config.go:26:6: exported: exported type GSSAPIConfig should have comment or be unexported (revive)
 internal/config/config.go:33:6: exported: exported type ServerConfig should have comment or be unexported (revive)
-internal/config/config.go:55:6: exported: exported type HttpSettingsConfig should have comment or be unexported (revive)
-internal/config/config.go:63:6: exported: exported type LFSConfig should have comment or be unexported (revive)
-internal/config/config.go:67:6: exported: exported type PATConfig should have comment or be unexported (revive)
-internal/config/config.go:72:6: exported: exported type Config should have comment or be unexported (revive)
-internal/config/config.go:78:2: var-naming: struct field GitlabUrl should be GitlabURL (revive)
-internal/config/config.go:85:2: var-naming: struct field HttpSettings should be HTTPSettings (revive)
-internal/config/config.go:130:1: exported: exported method YamlDuration.UnmarshalYAML should have comment or be unexported (revive)
-internal/config/config.go:141:1: exported: exported method Config.ApplyGlobalState should have comment or be unexported (revive)
-internal/config/config.go:143:12: Error return value of `os.Setenv` is not checked (errcheck)
-internal/config/config.go:147:1: exported: exported method Config.HTTPClient should have comment or be unexported (revive)
-internal/config/config.go:194:9: copylocks: assignment copies lock value to *cfg: gitlab.com/gitlab-org/gitlab-shell/v14/internal/config.Config contains sync.Once contains sync/atomic.Uint32 contains sync/atomic.noCopy (govet)
-internal/config/config.go:197:22: G304: Potential file inclusion via variable (gosec)
-internal/config/config.go:208:3: var-naming: var unescapedUrl should be unescapedURL (revive)
-internal/config/config.go:254:1: receiver-naming: receiver name cfg should be consistent with previous receiver name c for Config (revive)
+internal/config/config.go:64:6: exported: exported type LFSConfig should have comment or be unexported (revive)
+internal/config/config.go:68:6: exported: exported type PATConfig should have comment or be unexported (revive)
+internal/config/config.go:73:6: exported: exported type Config should have comment or be unexported (revive)
+internal/config/config.go:79:2: var-naming: struct field GitlabUrl should be GitlabURL (revive)
+internal/config/config.go:131:1: exported: exported method YamlDuration.UnmarshalYAML should have comment or be unexported (revive)
+internal/config/config.go:142:1: exported: exported method Config.ApplyGlobalState should have comment or be unexported (revive)
+internal/config/config.go:144:12: Error return value of `os.Setenv` is not checked (errcheck)
+internal/config/config.go:196:9: copylocks: assignment copies lock value to *cfg: gitlab.com/gitlab-org/gitlab-shell/v14/internal/config.Config contains sync.Once contains sync/atomic.Uint32 contains sync/atomic.noCopy (govet)
+internal/config/config.go:199:22: G304: Potential file inclusion via variable (gosec)
+internal/config/config.go:210:3: var-naming: var unescapedUrl should be unescapedURL (revive)
+internal/config/config.go:256:1: receiver-naming: receiver name cfg should be consistent with previous receiver name c for Config (revive)
 internal/console/console.go:39:13: Error return value of `fmt.Fprint` is not checked (errcheck)
 internal/console/console.go:65:13: Error return value of `fmt.Fprint` is not checked (errcheck)
 internal/console/console.go:67:13: Error return value of `fmt.Fprint` is not checked (errcheck)
@@ -348,7 +341,7 @@ internal/gitlabnet/accessverifier/client_test.go:280:6: go-require: do not use r
 internal/gitlabnet/accessverifier/client_test.go:301:5: go-require: do not use require in http handlers (testifylint)
 internal/gitlabnet/accessverifier/client_test.go:305:5: go-require: do not use require in http handlers (testifylint)
 internal/gitlabnet/client.go:1:1: package-comments: should have a package comment (revive)
-internal/gitlabnet/client.go:15:2: error-naming: error var ParsingError should have name of the form ErrFoo (revive)
+internal/gitlabnet/client.go:15:2: exported: exported var ParsingError should have comment or be unexported (revive)
 internal/gitlabnet/client.go:18:1: exported: exported function GetClient should have comment or be unexported (revive)
 internal/gitlabnet/client.go:25:15: ST1005: error strings should not be capitalized (stylecheck)
 internal/gitlabnet/client.go:31:1: exported: exported function ParseJSON should have comment or be unexported (revive)