As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
Commit f7b0c2f4 authored by Stan Hu's avatar Stan Hu
Browse files

Merge branch 'id-calculate-started-just-before-session-handling' into 'main'

Calculate session start after the connection is established

See merge request gitlab-org/gitlab-shell!653
parents fc6c2e16 1fe75fb5
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -171,7 +171,6 @@ func (s *Server) handleConn(ctx context.Context, nconn net.Conn) {
}
}()
started := time.Now()
conn := newConnection(s.Config, nconn)
conn.handle(ctx, s.serverConfig.get(ctx), func(sconn *ssh.ServerConn, channel ssh.Channel, requests <-chan *ssh.Request) error {
session := &session{
Loading
Loading
@@ -179,7 +178,7 @@ func (s *Server) handleConn(ctx context.Context, nconn net.Conn) {
channel: channel,
gitlabKeyId: sconn.Permissions.Extensions["key-id"],
remoteAddr: remoteAddr,
started: started,
started: time.Now(),
}
return session.handle(ctx, requests)
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment