As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
Commit f82854df authored by Ash McKenzie's avatar Ash McKenzie
Browse files

Merge branch '602-fix-race-in-test' into 'main'

Use blocking reader to fix race in test

Closes #602

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/700



Merged-by: default avatarAsh McKenzie <amckenzie@gitlab.com>
Approved-by: default avatarAsh McKenzie <amckenzie@gitlab.com>
Co-authored-by: default avatarPatrick Bajao <ebajao@gitlab.com>
parents 75f18461 b4277440
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -177,7 +177,7 @@ func TestCanceledContext(t *testing.T) {
cmd := &Command{
Config: &config.Config{GitlabUrl: url},
Args: &commandargs.Shell{GitlabKeyId: "wait_infinitely"},
ReadWriter: &readwriter.ReadWriter{Out: output, In: &bytes.Buffer{}},
ReadWriter: &readwriter.ReadWriter{Out: output, In: &blockingReader{}},
}
ctx, cancel := context.WithCancel(context.Background())
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment