- May 23, 2022
-
-
Igor Drozdov authored
The config option is basically a copy of LoginGraceTime OpenSSH option. If an SSH connection is hanging unauthenticated, after some period of time, the connection gets canceled. The value is configurable, the server waits for 60 seconds by default.
-
Stan Hu authored
Close the connection when context is canceled See merge request gitlab-org/gitlab-shell!646
-
Igor Drozdov authored
When graceful shutdown timeout expires, the global context is canceled. All the operations dependent on it are canceled as well. Unfortunately, some of the operations doesn't respect the context. For example, SSH connection initialization. In this case, we need to manually close the connection. One of the options is to wait for ctx.Done() and close the connection
-
Igor Drozdov authored
-
Igor Drozdov authored
Release v14.6.1 See merge request gitlab-org/gitlab-shell!645
-
Igor Drozdov authored
- Return support for diffie-hellman-group14-sha1 !644
-
Igor Drozdov authored
Return support for diffie-hellman-group14-sha1 See merge request gitlab-org/gitlab-shell!644
-
Igor Drozdov authored
It seems that a lot of users rely on this, let's return it and deprecated later to make the migration less disruptive
-
- May 21, 2022
-
-
Igor Drozdov authored
Release 14.6.0 See merge request gitlab-org/gitlab-shell!643
-
Igor Drozdov authored
- Exclude Gitaly unavailable error from error rate !641 - Downgrade auth EOF messages from warning to debug !641 - Display constistently in gitlab-sshd and gitlab-shell !641 - Downgrade host key mismatch messages from warning to debug !639 - Introduce a GitLab-SSHD server version during handshake !640 - Narrow supported kex algorithms !638
-
Stan Hu authored
Exclude Gitaly unavailable error from error rate See merge request gitlab-org/gitlab-shell!641
-
Igor Drozdov authored
The errors happen when a client closes a connection on handshake They can be ignored to avoid noise
-
Igor Drozdov authored
When a user hits repository rate limit, Gitaly returns an error that the request can't be handled (Gitaly unavailable) We should avoid this error to avoid exceeding the error rate
-
Igor Drozdov authored
- Use console package to format the errors in gitlab-sshd - Suppress internal Gitaly errors in client output
-
Igor Drozdov authored
Downgrade host key mismatch messages from warning to debug See merge request gitlab-org/gitlab-shell!639
-
Igor Drozdov authored
Introduce a GitLab-SSHD server version during handshake See merge request gitlab-org/gitlab-shell!640
-
-
- May 20, 2022
-
-
Stan Hu authored
This message doesn't provide that much value, so let's just drop it.
-
Stan Hu authored
In production, we often see SSH key scans requesting host key algorithms that we don't support, such as `sk-ssh-ed25519@openssh.com` or `sk-ecdsa-sha2-nistp256@openssh.com`. These messages might be useful if someone forgets to configure a host key that should be supported, but most of the time they are noise. This commit downgrades these messages to DEBUG. Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/581 Changelog: changed
-
Stan Hu authored
Narrow supported kex algorithms See merge request gitlab-org/gitlab-shell!638
-
Igor Drozdov authored
We don't support diffie-hellman-group14-sha1 via OpenSSH currently Let's avoid introducing it in gitlab-sshd because it's using weak hashing algorithm
-
- May 19, 2022
-
-
Stan Hu authored
Release 14.5.0 See merge request gitlab-org/gitlab-shell!636
-
Stan Hu authored
- Make ProxyHeaderTimeout configurable !635
-
Stan Hu authored
Make ProxyHeaderTimeout configurable See merge request gitlab-org/gitlab-shell!635
-
Igor Drozdov authored
Issue: https://gitlab.com/gitlab-org/gitlab-shell/-/issues/576 ProxyHeaderTimeout must be small to avoid DoS risk Let's make the value configurable and 500ms by default
-
Igor Drozdov authored
- If an integer is specified, we assume that these are seconds - A duration of format "500ms", "10s", "1m", etc... accepted
-
- May 18, 2022
-
-
Igor Drozdov authored
Release 14.4.0 See merge request gitlab-org/gitlab-shell!634
-
Igor Drozdov authored
- Allow configuring SSH server algorithms !633 - Update gitlab-org/golang-crypto module version !632
-
Stan Hu authored
Allow configuring SSH server algorithms See merge request gitlab-org/gitlab-shell!633
-
Igor Drozdov authored
MACs, Ciphers and KEX algorithms now can be configured If the values are empty, reasonable defaults are used
-
Igor Drozdov authored
Update gitlab-org/golang-crypto module version See merge request gitlab-org/gitlab-shell!632
-
Stan Hu authored
This update pulls in: 1. https://gitlab.com/gitlab-org/golang-crypto/-/merge_requests/3, which syncs the module with upstream master and supports the new `curve25519-sha256@libssh.org` kex name. 2. https://gitlab.com/gitlab-org/golang-crypto/-/merge_requests/4, which adds: * MACs: hmac-sha2-512-etm@openssh.com, hmac-sha2-512 * Cipher: aes256-gcm@openssh.com Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/575
-
Igor Drozdov authored
Release v14.3.1 See merge request gitlab-org/gitlab-shell!631
-
Igor Drozdov authored
- Exclude API errors from error rate !630
-
Stan Hu authored
Exclude API errors from error rate See merge request gitlab-org/gitlab-shell!630
-
Igor Drozdov authored
When API isn't responsible or the resource is not accessible (returns 404 or 403), then we shouldn't consider it as an error on gitlab-sshd side
-
Igor Drozdov authored
Git ignore .DS_Store See merge request gitlab-org/gitlab-shell!629
-
Sean Carroll authored
-
- May 17, 2022
-
-
Igor Drozdov authored
Resolve "Dependency update DOCKER_VERSION: 20.10.15" Closes #571 See merge request gitlab-org/gitlab-shell!628
-
-