Release v13.5.0

See merge request gitlab-org/gitlab-shell!404

Generate and log correlation IDs

See merge request gitlab-org/gitlab-shell!400

Stan Hu authored 4 years ago and Igor Drozdov committed 4 years ago

This will make it easier to tie an SSH access request to Rails API and
Gitaly requests.

Revert "Update executable.go"

See merge request gitlab-org/gitlab-shell!403

This reverts commit 869aeb90

Release v13.4.0

See merge request gitlab-org/gitlab-shell!402

Log SSH key details

See merge request gitlab-org/gitlab-shell!398

Stan Hu authored 4 years ago and Igor Drozdov committed 4 years ago

Right now when a client such as gitlab-shell calls the
`/api/v4/internal/allowed` API, the response only tells the client what
user has been granted access, and it's impossible to tell which deploy
key/token was used in the authentication request.

This commit adds logs for the following when available:

1. `gl_key_type` (e.g. `deploy_key` or `key`)
2. `gl_key_id`

These fields make it possible for admins to identify the exact record
that was used to authenticate the user.

API changes in the `/internal/allowed` endpoint in
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37289 are needed
to support this.

Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/203

Log remote IP for executed commands

Closes #199

See merge request gitlab-org/gitlab-shell!399

Drop Go v1.12 support

See merge request gitlab-org/gitlab-shell!401

We officially use Go v1.13+ for everything
(https://docs.gitlab.com/ee/install/requirements.html#go-versions), and
dropping Go v1.12 allows us to use new methods such as
`http.NewRequestWithContext`.

Admins may want to know what client IP originated the request. This
commit adds a `remote_ip` field to the log that extracts the IP address
from the `SSH_CONNECTION` environment variable.

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/199

Merge branch '459-system-default-ssl_cert_dir-is-being-used-during-remote-gitaly-over-tls' into 'master'

Support ssl_cert_dir config setting

See merge request gitlab-org/gitlab-shell!393

Extract coverage for Go code on CI pipeline

See merge request gitlab-org/gitlab-shell!392

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>

Use simplified setup for code intelligence

See merge request gitlab-org/gitlab-shell!386

Use codequality CI template

See merge request gitlab-org/gitlab-shell!389

In https://gitlab.com/gitlab-org/gitlab/-/issues/218797, it was
determined that gitlab-shell is using an outdated image that no
longer exists.

To ensure that we are using up to date codequality image, we
can use the built-in template instead.

Release v13.3.0

See merge request gitlab-org/gitlab-shell!391

Upgrade Ruby version to v2.6.6

See merge request gitlab-org/gitlab-shell!390

GitLab has now been upgraded to use Ruby 2.6.6:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/33253

Use default puma socket in example config

See merge request gitlab-org/gitlab-shell!388

The unicorn replacement 'puma' uses a unix socket in the example config [1] instead of a tcp port.
Using the non-existing tcp port results in "Internal API unreachable" on
git operations.

[1] https://gitlab.com/gitlab-org/gitlab/-/blob/master/config/puma.rb.example#L34

Set client name when making requests to Gitaly

See merge request gitlab-org/gitlab-shell!387

Fix race conditions with logrus testing

Closes #450

See merge request gitlab-org/gitlab-shell!385

Add race testing as separate CI step

See merge request gitlab-org/gitlab-shell!383

Release v13.2.0

See merge request gitlab-org/gitlab-shell!384

logrus fires a Goroutine to write logs, so the tests could fail if they
checked the event queue before the logrus have fired.  Since there isn't
an easy way to flush all outstanding hooks, we just retry every 100 ms
for up to a second for log to arrive in the queue.

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450

This would help catch race conditions such as
https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450 before merge.

Add HTTP status code to internal API logs

Closes #450

See merge request gitlab-org/gitlab-shell!376