- Jul 04, 2023
-
-
Ash McKenzie authored
-
- Jun 20, 2023
-
-
- Jun 06, 2023
-
-
GitLab Renovate Bot authored
This explicitly imports gitaly v16 instead of v15 and removes the old one from `go.mod`.
-
- May 11, 2023
-
-
Joe Woodward authored
Prior to this change personal access tokens without a ttl would never expire. In Gitlab 15.4 we deprecated non-expiring tokens and are scheduled for removal in 16.0. https://gitlab.com/gitlab-org/gitlab/-/issues/369122 This change alters the gitlab-shell command for creating tokens to ensure add a default limit of 30 days. Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/640
-
- Apr 26, 2023
-
-
Mohamed Saber authored
-
- Mar 17, 2023
-
-
Igor Drozdov authored
It imitates a push to the secondary and verifies that the push is redirected to the primary
-
- Mar 15, 2023
-
-
Patrick Cyiza authored
-
- Jan 23, 2023
-
-
- Nov 23, 2022
-
-
James Fargher authored
-
James Fargher authored
-
- Aug 05, 2022
-
-
Igor Drozdov authored
This commit also excludes gitlab-shell from dependencies: Gitaly specifies Gitlab Shell as a dependency as well in order to use gitlabnet client to perform API endpoints to Gitlab Rails. As a result, Gitlab Shell requires Gitaly -> Gitaly requires an older version of Gitlab Shell -> that version requires an older version of Gitlab Shell, etc. Let's use exclude to break the chain earlier
-
Igor Drozdov authored
After https://gitlab.com/gitlab-org/gitaly/-/merge_requests/4766 has been introduced, the test started fail because we basically cancel the git-receive-pack after the output is received This commit gracefully closes the connection to make the test pass
-
- Jul 05, 2022
-
-
Patrick Steinhardt authored
While gitlab-shell currently has a major version of v14, the module path it exposes is not using that major version like it is required by the Go standard. This makes it impossible for dependents to import gitlab-shell as a dependency without using a commit as version. Fix this by changing the module path of gitlab-shell to instead be `gitlab.com/gitlab-org/gitlab-shell/v14` and adjust all imports accordingly. Changelog: fixed
-
- May 19, 2022
-
-
Igor Drozdov authored
- If an integer is specified, we assume that these are seconds - A duration of format "500ms", "10s", "1m", etc... accepted
-
- May 05, 2022
-
-
Igor Drozdov authored
New version of LabKit provides FIPS checks that we can use instead of the custom code
-
- Apr 18, 2022
-
-
Stan Hu authored
This commit adds support of using a FIPS-validated SSL library with compiled Go executables when `FIPS_MODE=1 make` is run. A Go compiler that supports BoringSSL either directly (e.g. the `dev.boringcrypto` branch) or with a dynamically linked OpenSSL (e.g. https://github.com/golang-fips/go) is required. This is similar to the changes to support FIPS in GitLab Runner and in GitLab Pages: https://gitlab.com/gitlab-org/gitlab-pages/-/merge_requests/716 Changelog: added
-
- Mar 07, 2022
-
-
Igor Drozdov authored
When gitlab-sshd has been introduced we've started running our own SSH server. In this case we're able to cache and reuse Gitaly connections and Registry. It helps to reduce memory usage.
-
- Dec 28, 2021
-
-
Will Chandler authored
Until recently, Gitaly was silently swallowing any errors returned by SSH `git upload-pack` processes. Clients would still receive stderr output and a non-zero return code, but Gitlab-Shell would receive error as nil and log success. With 9deaf47f1ecb00f0f36d18ee4a0fb1576f5a0efe Gitaly will now return an error when git fails, but this causes Gitlab-Shell to print out the GRPC error code as a message to the client: > fatal: couldn't find remote ref not-a-real-ref > fatal: the remote end hung up unexpectedly > remote: > remote: > ======================================================================== > remote: > remote: rpc error: code = Internal desc = SSHUploadPack: exit status 128 > remote: > remote: > ======================================================================== > remote: The `remote:` text gives no additional context for the user and adds clutter. This commit suppresses the additional message added by Gitlab-Shell on failure when the error type is `Internal`, returning client output to the format it was prior to the Gitaly change.
-
- Dec 22, 2021
-
-
Will Chandler authored
Before 9deaf47f1ecb00f0f36d18ee4a0fb1576f5a0efe, Gitaly would return success for `SSHUploadPack` and `SSHUploadArchive` regardless of the exit code of the `git upload-pack|archive` process. As a result, the gitlab-sshd acceptance tests could rely on no errors being returned from Gitaly. Currently these tests send the minimum request needed to start a session, causing the server git process to fail as the `0000` flush packet to end the session is never sent. This commit fixes the tests by sending the full request/response needed for a successful git operation.
-
- Nov 11, 2021
-
-
Stan Hu authored
Due to the way sshd works, gitlab-shell could be called with a single string in the form: ``` /path/to/gitlab-shell -c key-id ``` However, due to the tightening of the regular expressions in fcff692b this string no longer matches, so logins would fail with: ``` Failed to get username: who='' is invalid ``` This can be reproduced by changing the user's shell to point to gitlab-shell. For example: ``` usermod git -s /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell ``` While setting gitlab-shell as the user's shell isn't officially supported, gitlab-shell still should be able to cope with the key being specified as the last argument. We now split the argument list and use the last value. Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/530
-
- Oct 07, 2021
-
-
Nick Thomas authored
Use reflection to log the command we are about to execute, both in gitlab-shell and gitlab-sshd. Include the environment, which has all the context we need to understand what the command is expected to do. Changelog: added
-
- Sep 27, 2021
-
-
Nick Thomas authored
-
- Sep 20, 2021
-
-
- Sep 15, 2021
-
-
Igor Drozdov authored
It adds correlation ids wherever possible
-
- Sep 08, 2021
- Aug 19, 2021
-
-
feistel authored
-
- Aug 04, 2021
-
-
Nick Thomas authored
- We start supporting the "color" format for logs. - We now respond to SIGHUP by reopening the log file. - We now respect the log format when no log filename is specified. Output to syslog in the event of logging system setup is preserved in OpenSSH mode. Changelog: added
-
- Jul 27, 2021
-
-
Igor Drozdov authored
-
- Jul 26, 2021
-
-
Stan Hu authored
-
- Jul 22, 2021
-
-
Igor Drozdov authored
-
- Jul 19, 2021
-
-
Igor Drozdov authored
They are going to be used to determine whether a server is alive and ready to accept traffic
-
- Jul 15, 2021
-
-
Igor Drozdov authored
When interruption signal is sent, we are closing ssh listener to prevent it from accepting new connections Then after configured grace period, we cancel the context to cancel all ongoing operations
-
- Jul 14, 2021
-
-
Igor Drozdov authored
-
- Jun 02, 2021
-
-
Pavlo Strokov authored
Gitaly project now properly respects module release flow and includes a module suffix in the package name. It requires to re-write all non-suffixed imports with suffixed of a specific version of tha module. With proper module versioning we don't need to use a 'replace' directive to point to specific commit and can use semantic versioning for the gitaly dependency. Part of: https://gitlab.com/gitlab-org/gitaly/-/issues/3177
-
- Jun 01, 2021
-
-
Vasilii Iakliushin authored
Contributes to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/500
-
Vasilii Iakliushin authored
Contributes to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/500
-
- May 20, 2021
-
-
Sean McGivern authored
-