- Jun 06, 2022
-
-
Igor Drozdov authored
Release 14.7.2 See merge request gitlab-org/gitlab-shell!655
-
Igor Drozdov authored
- Exclude disallowed command from error rate
-
Patrick Bajao authored
Exclude disallowed command from error rate See merge request gitlab-org/gitlab-shell!654
-
- Jun 01, 2022
-
-
Igor Drozdov authored
-
- May 25, 2022
-
-
Igor Drozdov authored
Release 14.7.1 See merge request gitlab-org/gitlab-shell!652
-
Igor Drozdov authored
- Log gitlab-sshd session level indicator errors !650 - Improve establish session duration metrics !651
-
Stan Hu authored
Calculate session start after the connection is established See merge request gitlab-org/gitlab-shell!653
-
Igor Drozdov authored
-
Stan Hu authored
Improve establish session duration metrics See merge request gitlab-org/gitlab-shell!651
-
Igor Drozdov authored
Before we took into account the time a user takes to authenticate Now it only measures the time between a connection established and a command started to being executed It's still can be controlled by a user, but it's something we can measure and restrict if necessary
-
Igor Drozdov authored
Log gitlab-sshd session level indicator errors See merge request gitlab-org/gitlab-shell!650
-
- May 24, 2022
-
-
Stan Hu authored
In production, we saw gitlab-sshd error metrics rise, but it was not clear why. We now log a message every time we encounter a session error that affects the service level indicator counter.
-
Igor Drozdov authored
Document gitlab-shell on GitLab SaaS See merge request gitlab-org/gitlab-shell!625
-
- May 23, 2022
-
-
Stan Hu authored
Release v14.7.0 See merge request gitlab-org/gitlab-shell!648
-
Stan Hu authored
- Abort long-running unauthenticated SSH connections !647 - Close the connection when context is canceled !646
-
Stan Hu authored
Abort long-running unauthenticated SSH connections See merge request gitlab-org/gitlab-shell!647
-
Igor Drozdov authored
-
Igor Drozdov authored
The config option is basically a copy of LoginGraceTime OpenSSH option. If an SSH connection is hanging unauthenticated, after some period of time, the connection gets canceled. The value is configurable, the server waits for 60 seconds by default.
-
Stan Hu authored
Close the connection when context is canceled See merge request gitlab-org/gitlab-shell!646
-
Igor Drozdov authored
When graceful shutdown timeout expires, the global context is canceled. All the operations dependent on it are canceled as well. Unfortunately, some of the operations doesn't respect the context. For example, SSH connection initialization. In this case, we need to manually close the connection. One of the options is to wait for ctx.Done() and close the connection
-
Igor Drozdov authored
-
Igor Drozdov authored
Release v14.6.1 See merge request gitlab-org/gitlab-shell!645
-
Igor Drozdov authored
- Return support for diffie-hellman-group14-sha1 !644
-
Igor Drozdov authored
Return support for diffie-hellman-group14-sha1 See merge request gitlab-org/gitlab-shell!644
-
Igor Drozdov authored
It seems that a lot of users rely on this, let's return it and deprecated later to make the migration less disruptive
-
- May 21, 2022
-
-
Igor Drozdov authored
Release 14.6.0 See merge request gitlab-org/gitlab-shell!643
-
Igor Drozdov authored
- Exclude Gitaly unavailable error from error rate !641 - Downgrade auth EOF messages from warning to debug !641 - Display constistently in gitlab-sshd and gitlab-shell !641 - Downgrade host key mismatch messages from warning to debug !639 - Introduce a GitLab-SSHD server version during handshake !640 - Narrow supported kex algorithms !638
-
Stan Hu authored
Exclude Gitaly unavailable error from error rate See merge request gitlab-org/gitlab-shell!641
-
Igor Drozdov authored
The errors happen when a client closes a connection on handshake They can be ignored to avoid noise
-
Igor Drozdov authored
When a user hits repository rate limit, Gitaly returns an error that the request can't be handled (Gitaly unavailable) We should avoid this error to avoid exceeding the error rate
-
Igor Drozdov authored
- Use console package to format the errors in gitlab-sshd - Suppress internal Gitaly errors in client output
-
Igor Drozdov authored
Downgrade host key mismatch messages from warning to debug See merge request gitlab-org/gitlab-shell!639
-
Igor Drozdov authored
Introduce a GitLab-SSHD server version during handshake See merge request gitlab-org/gitlab-shell!640
-
-
- May 20, 2022
-
-
Stan Hu authored
This message doesn't provide that much value, so let's just drop it.
-
Stan Hu authored
In production, we often see SSH key scans requesting host key algorithms that we don't support, such as `sk-ssh-ed25519@openssh.com` or `sk-ecdsa-sha2-nistp256@openssh.com`. These messages might be useful if someone forgets to configure a host key that should be supported, but most of the time they are noise. This commit downgrades these messages to DEBUG. Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/581 Changelog: changed
-
Stan Hu authored
Narrow supported kex algorithms See merge request gitlab-org/gitlab-shell!638
-
Igor Drozdov authored
We don't support diffie-hellman-group14-sha1 via OpenSSH currently Let's avoid introducing it in gitlab-sshd because it's using weak hashing algorithm
-
- May 19, 2022