- Jun 16, 2022
-
-
Igor Drozdov authored
- Update crypto module to fix RSA keys with old gpg-agent
-
Igor Drozdov authored
gitlab-sshd: Update crypto module to fix RSA keys with old gpg-agent See merge request gitlab-org/gitlab-shell!662
-
Stan Hu authored
When we put gitlab-sshd in production, we noticed a number of clients using RSA keys would fail to login. The server would report: ``` ssh: signature "ssh-rsa" not compatible with selected algorithm "rsa-sha2-512" ``` This is reproducible on Ubuntu 18.04, which ships gpg-agent v2.2.4 and OpenSSH v7.6. That version of gpg-agent does not support `rsa-sha2-256` or `rsa-sha2-512`, but OpenSSH does. As a result, OpenSSH specifies `rsa-sha-512` as the public key algorithm to use in the user authentication request message, but gpg-agent includes an `ssh-rsa` signature. OpenSSH servers tolerates this discrepancy, but the Go implementation fails because it expects a strict match. This commit pulls in https://gitlab.com/gitlab-org/golang-crypto/-/merge_requests/9 to fix the problem. Relates to: 1. https://github.com/golang/go/issues/53391 2. https://gitlab.com/gitlab-org/gitlab-shell/-/issues/587 Changelog: fixed
-
- Jun 14, 2022
-
-
Igor Drozdov authored
Set BUNDLE_FROZEN to true Closes #562 See merge request gitlab-org/gitlab-shell!659
-
- Jun 10, 2022
-
-
Alejandro Rodríguez authored
To follow rubygems' security adisory https://github.com/rubygems/rubygems.org/security/advisories/GHSA-hccv-rwq6-vh79:
-
- Jun 07, 2022
-
-
Igor Drozdov authored
Upgrade Gemfile.lock to use bundler to v2.3.15 See merge request gitlab-org/gitlab-shell!658
-
Stan Hu authored
This is just to minimize the versions of bundler used for development. The GDK runs `support/bundle-install` in this directory to obtain the version of bundler needed. This relates to https://gitlab.com/gitlab-org/gitlab/-/issues/364373.
-
- Jun 06, 2022
-
-
Igor Drozdov authored
Release v14.7.3 See merge request gitlab-org/gitlab-shell!657
-
Igor Drozdov authored
- Ignore "not our ref" errors from gitlab-sshd error metrics
-
Igor Drozdov authored
Ignore "not our ref" errors from gitlab-sshd error metrics See merge request gitlab-org/gitlab-shell!656
-
Stan Hu authored
If a client requests a ref that cannot be found in the repository, previously gitlab-sshd would record it as part of its service level indicator metric. This is really an application error between the client and the Git repository, so we exclude it from our metrics. Relates to https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/15848 Changelog: fixed
-
Igor Drozdov authored
Release 14.7.2 See merge request gitlab-org/gitlab-shell!655
-
Igor Drozdov authored
- Exclude disallowed command from error rate
-
Patrick Bajao authored
Exclude disallowed command from error rate See merge request gitlab-org/gitlab-shell!654
-
- Jun 01, 2022
-
-
Igor Drozdov authored
-
- May 25, 2022
-
-
Igor Drozdov authored
Release 14.7.1 See merge request gitlab-org/gitlab-shell!652
-
Igor Drozdov authored
- Log gitlab-sshd session level indicator errors !650 - Improve establish session duration metrics !651
-
Stan Hu authored
Calculate session start after the connection is established See merge request gitlab-org/gitlab-shell!653
-
Igor Drozdov authored
-
Stan Hu authored
Improve establish session duration metrics See merge request gitlab-org/gitlab-shell!651
-
Igor Drozdov authored
Before we took into account the time a user takes to authenticate Now it only measures the time between a connection established and a command started to being executed It's still can be controlled by a user, but it's something we can measure and restrict if necessary
-
Igor Drozdov authored
Log gitlab-sshd session level indicator errors See merge request gitlab-org/gitlab-shell!650
-
- May 24, 2022
-
-
Stan Hu authored
In production, we saw gitlab-sshd error metrics rise, but it was not clear why. We now log a message every time we encounter a session error that affects the service level indicator counter.
-
Igor Drozdov authored
Document gitlab-shell on GitLab SaaS See merge request gitlab-org/gitlab-shell!625
-
- May 23, 2022
-
-
Stan Hu authored
Release v14.7.0 See merge request gitlab-org/gitlab-shell!648
-
Stan Hu authored
- Abort long-running unauthenticated SSH connections !647 - Close the connection when context is canceled !646
-
Stan Hu authored
Abort long-running unauthenticated SSH connections See merge request gitlab-org/gitlab-shell!647
-
Igor Drozdov authored
-
Igor Drozdov authored
The config option is basically a copy of LoginGraceTime OpenSSH option. If an SSH connection is hanging unauthenticated, after some period of time, the connection gets canceled. The value is configurable, the server waits for 60 seconds by default.
-
Stan Hu authored
Close the connection when context is canceled See merge request gitlab-org/gitlab-shell!646
-
Igor Drozdov authored
When graceful shutdown timeout expires, the global context is canceled. All the operations dependent on it are canceled as well. Unfortunately, some of the operations doesn't respect the context. For example, SSH connection initialization. In this case, we need to manually close the connection. One of the options is to wait for ctx.Done() and close the connection
-
Igor Drozdov authored
-
Igor Drozdov authored
Release v14.6.1 See merge request gitlab-org/gitlab-shell!645
-
Igor Drozdov authored
- Return support for diffie-hellman-group14-sha1 !644
-
Igor Drozdov authored
Return support for diffie-hellman-group14-sha1 See merge request gitlab-org/gitlab-shell!644
-
Igor Drozdov authored
It seems that a lot of users rely on this, let's return it and deprecated later to make the migration less disruptive
-
- May 21, 2022
-
-
Igor Drozdov authored
Release 14.6.0 See merge request gitlab-org/gitlab-shell!643
-
Igor Drozdov authored
- Exclude Gitaly unavailable error from error rate !641 - Downgrade auth EOF messages from warning to debug !641 - Display constistently in gitlab-sshd and gitlab-shell !641 - Downgrade host key mismatch messages from warning to debug !639 - Introduce a GitLab-SSHD server version during handshake !640 - Narrow supported kex algorithms !638
-
Stan Hu authored
Exclude Gitaly unavailable error from error rate See merge request gitlab-org/gitlab-shell!641
-
Igor Drozdov authored
The errors happen when a client closes a connection on handshake They can be ignored to avoid noise
-