Changelog: added

Instead of interpreting the configuration for every new connection, we
can rely on a closure to simplify the proxy handler path. This is more
similar to how the provided MustStrictWhiteListPolicy works which will
be added in a later commit.

Fix broken Gitaly integration tests

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/694



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Patrick Bajao <ebajao@gitlab.com>

Gitaly started to require `Repository` information for certain
commands like upload-pack, upload-archive, and receive-pack.

However, gitlab-shell tests are sending `git_object_directory` and
`git_alternate_object_directories` that do not exist.

To fix the tests, we set those to an existing directory in the
created repository.

Clean up go.sum by updating libraries in go.mod

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/692



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

It also excludes 1.12.1 version to break the cycling dependency
that loads a lot of obsolete libraries

The changes are the result of running

go mod tidy -compat=1.17

We don't support 1.16 for a while, this command just cleans up the
unnecessary dependencies

Improve error message for Gitaly `LimitError`s

Closes #556

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/691



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Alejandro Rodríguez <alejorro70@gmail.com>

Release 14.13.0 version

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/690



Merged-by: Igor Drozdov <idrozdov@gitlab.com>

- Update .tool-versions to Go 1.18.7
- Remove secret from request headers

Remove secret from request headers

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/689



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

Now the requests are verified via JWT

Update .tool-versions to Go 1.18.7

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/688



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Stan Hu <stanhu@gmail.com>

Security announcement: https://groups.google.com/g/golang-announce/c/xtuG5faxtaU

Part of https://gitlab.com/groups/gitlab-org/-/epics/8843

Release v14.12.0

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/687



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>

- Trim secret before signing JWT tokens !686
- Bump .tool-versions to use Go 1.18.6 !685
- Update Gitaly to 15.4.0-rc2 !681
- Test against Golang v1.19 !680

Trim secret before signing JWT tokens

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/686



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

With this change we don't rely on the secret to either contain
a newline or not contain it.

Bump .tool-versions to use Go 1.18.6

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/685



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Stan Hu <stanhu@gmail.com>

go 1.17 is no longer receiving security updates. Update to go 1.18 in
preparation for upgrading.

Part of https://gitlab.com/groups/gitlab-org/-/epics/8843

Update docs metadata link in gitlab-shell repo

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/684



Merged-by: Alejandro Rodríguez <alejandro@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Co-authored-by: Amy Qualls <aqualls@gitlab.com>

Add developer documentation to command package

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/594



Merged-by: Patrick Bajao <ebajao@gitlab.com>
Approved-by: Patrick Bajao <ebajao@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

Update Gitaly to 15.4.0-rc2

See merge request gitlab-org/gitlab-shell!681

It has gitlab-shell dependency removed, so it makes sense to
remove the exclusion of circular dependency

Run tests agains 1.19 Golang

See merge request gitlab-org/gitlab-shell!680

Update gitlab-dangerfiles gem

See merge request gitlab-org/gitlab-shell!678

Release 14.11.0

See merge request gitlab-org/gitlab-shell!677

Update Gitaly to v15

See merge request gitlab-org/gitlab-shell!676

Fixed extra slashes in API request paths generated for geo

See merge request gitlab-org/gitlab-shell!673

This commit also excludes gitlab-shell from dependencies:

Gitaly specifies Gitlab Shell as a dependency as well in order
to use gitlabnet client to perform API endpoints to Gitlab Rails.
As a result, Gitlab Shell requires Gitaly -> Gitaly requires an
older version of Gitlab Shell -> that version requires an older
version of Gitlab Shell, etc. Let's use exclude to break the
chain earlier

Fix failing TestGitReceivePackSuccess

See merge request gitlab-org/gitlab-shell!675

After https://gitlab.com/gitlab-org/gitaly/-/merge_requests/4766
has been introduced, the test started fail because we basically
cancel the git-receive-pack after the output is received

This commit gracefully closes the connection to make the test
pass