As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
  1. Nov 05, 2020
  2. Oct 16, 2020
  3. Jun 06, 2020
  4. May 11, 2020
  5. Oct 18, 2019
  6. Oct 15, 2019
  7. Oct 08, 2019
  8. Aug 15, 2019
    • Patrick Bajao's avatar
      Replace symlinks with actual binaries · 41f919eb
      Patrick Bajao authored
      We had `gitlab-shell-authorized-keys-check` and
      `gitlab-shell-authorized-principals-check` as symlinks to
      `gitlab-shell` before.
      
      We determine the `Command` and `CommandArgs` that we build based
      on the `Name` of the `Executable`. We also use that to know which
      fallback ruby executable should we fallback to. We use
      `os.Executable()` to do that.
      
      `os.Executable()` behaves differently depending on OS. It may
      return the symlink or the target's name. That can result to a
      buggy behavior.
      
      The fix is to create binaries for each instead of using a symlink.
      That way we don't need to rely on `os.Executable()` to get the name.
      We pass the `Name` of the executable instead.
      41f919eb
  9. Jul 29, 2019
    • Patrick Bajao's avatar
      Support falling back to ruby version of checkers · aab85f36
      Patrick Bajao authored
      Rename the ruby scripts to have `-ruby` suffix and add a symlink
      for both to `./gitlab-shell`. The executable name will be used to
      determine how args will be parsed.
      
      For now, we only parse the arguments for gitlab-shell commands. If
      the executable is `gitlab-shell-authorized-keys-check` or
      `gitlab-shell-authorized-principals-check`, it'll always fallback
      to the ruby version.
      
      Ruby specs test the ruby script, the fallback from go to ruby and
      go implementation of both (still pending).
      aab85f36
  10. Jun 28, 2019
  11. Jun 27, 2019
  12. Jan 12, 2018
  13. Jul 22, 2017
  14. May 12, 2016
Loading