Use Ruby 2.7.7 as the default

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/699



Merged-by: Patrick Bajao <ebajao@gitlab.com>
Approved-by: Patrick Bajao <ebajao@gitlab.com>
Co-authored-by: Ash McKenzie <amckenzie@gitlab.com>

Use blocking reader to fix race in test

Closes #602

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/700



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Patrick Bajao <ebajao@gitlab.com>

The `TestCanceledContext` test in `twofactorverify_test.go` tests
the scenario wherein the request context gets canceled in the
middle of the request.

A race can occur though when the input gets read before the context
is canceled which can result to a different error: instead of
having the context canceled, the OTP will be blank.

To fix it, we use a blocking reader as input to simulate "waiting
for input" scenario. This way, reading the input will never be
finished and the context cancelation can be done appropriately.

Use the images provided by Gitlab to run tests

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/698



Merged-by: Patrick Bajao <ebajao@gitlab.com>
Approved-by: Patrick Bajao <ebajao@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

That would save us from installing additional
dependencies ourselves

Add developer documentation to sshd package

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/683



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Approved-by: Oscar Tovar <otovar@gitlab.com>
Approved-by: James Fargher <proglottis@gmail.com>
Approved-by: John Cai <jcai@gitlab.com>
Approved-by: Amy Qualls <aqualls@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

Restrict IP access for PROXY protocol

Closes #577

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/693



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Co-authored-by: James Fargher <jfargher@gitlab.com>

Clean up .gitlab-ci.yml file

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/695



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

MustStrictWhiteListPolicy panics when configured incorrectly. So here we
use the error returning version instead.

Changelog: added

Instead of interpreting the configuration for every new connection, we
can rely on a closure to simplify the proxy handler path. This is more
similar to how the provided MustStrictWhiteListPolicy works which will
be added in a later commit.

Fix broken Gitaly integration tests

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/694



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Patrick Bajao <ebajao@gitlab.com>

Gitaly started to require `Repository` information for certain
commands like upload-pack, upload-archive, and receive-pack.

However, gitlab-shell tests are sending `git_object_directory` and
`git_alternate_object_directories` that do not exist.

To fix the tests, we set those to an existing directory in the
created repository.

Clean up go.sum by updating libraries in go.mod

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/692



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

It also excludes 1.12.1 version to break the cycling dependency
that loads a lot of obsolete libraries

The changes are the result of running

go mod tidy -compat=1.17

We don't support 1.16 for a while, this command just cleans up the
unnecessary dependencies

Improve error message for Gitaly `LimitError`s

Closes #556

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/691



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Alejandro Rodríguez <alejorro70@gmail.com>

Release 14.13.0 version

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/690



Merged-by: Igor Drozdov <idrozdov@gitlab.com>

- Update .tool-versions to Go 1.18.7
- Remove secret from request headers

Remove secret from request headers

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/689



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

Now the requests are verified via JWT

Update .tool-versions to Go 1.18.7

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/688



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Stan Hu <stanhu@gmail.com>

Security announcement: https://groups.google.com/g/golang-announce/c/xtuG5faxtaU

Part of https://gitlab.com/groups/gitlab-org/-/epics/8843

Release v14.12.0

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/687



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>

- Trim secret before signing JWT tokens !686
- Bump .tool-versions to use Go 1.18.6 !685
- Update Gitaly to 15.4.0-rc2 !681
- Test against Golang v1.19 !680

Trim secret before signing JWT tokens

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/686



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

With this change we don't rely on the secret to either contain
a newline or not contain it.

Bump .tool-versions to use Go 1.18.6

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/685



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Stan Hu <stanhu@gmail.com>

go 1.17 is no longer receiving security updates. Update to go 1.18 in
preparation for upgrading.

Part of https://gitlab.com/groups/gitlab-org/-/epics/8843

Update docs metadata link in gitlab-shell repo

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/684



Merged-by: Alejandro Rodríguez <alejandro@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Co-authored-by: Amy Qualls <aqualls@gitlab.com>