As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
  1. Aug 01, 2018
  2. Jul 31, 2018
  3. Jul 27, 2018
  4. Jul 26, 2018
    • Ævar Arnfjörð Bjarmason's avatar
      Add support for SSH certificate authentication · 2e8b6702
      Ævar Arnfjörð Bjarmason authored
      This along with the code submitted to gitlab-ce in the
      gitlab-org/gitlab-ce! MR implements SSH certificate
      authentication. See the docs added to gitlab-ce for why and how to
      enable this. This, along with that MR, closes
      gitlab-org/gitlab-ce#3457
      
      Implementation notes:
      
       - Because it's easy to do, and because an earlier nascent version of
         this would pass user-ID to gitlab-shell, that's now supported, even
         though the SSH certificate authentication uses username-USERNAME.
      
       - The astute reader will notice that not all the API calls in
         gitlab-ce's lib/api/internal.rb support a "username" argument, some
         only support "user_id".
      
         There's a few reasons for this:
      
           a) For this to be efficient, I am bending over backwards to avoid
              extra API calls when using SSH certificates.
      
              Therefore the /allowed API call will now return a "user id" to
              us if we're allowed to proceed further. This is then fed to
              existing APIs that would only be called after a successful
              call to /allowed.
      
           b) Not all of the git-shell codepaths go through
              /internal/allowed, or ever deal with a repository, e.g. the
              argument-less "Welcome to GitLab", and
              /internal/2fa_recovery_codes. These need to use
              /internal/discover to figure out details about the user, so
              support looking that up by username.
      
           c) Once we have the "user id", the GL_ID gets passed down to
              e.g. user-authored hooks. I don't want to have those all break
              by having to handle a third GL_ID mode of "username" in
              addition to the current "key id" and "user id".
      2e8b6702
  5. Jul 24, 2018
  6. Jul 23, 2018
  7. Jul 20, 2018
  8. Jul 11, 2018
  9. Jun 20, 2018
  10. Jun 13, 2018
  11. Jun 12, 2018
  12. Jun 11, 2018
  13. Jun 04, 2018
  14. Jun 01, 2018
  15. May 28, 2018
  16. May 24, 2018
  17. May 23, 2018
    • Bob Van Landuyt's avatar
      Display the username instead of fullname · aa10b70f
      Bob Van Landuyt authored
      When running `ssh git@gitlab.example.com` we used to reply with the
      full name. But it might actually be more useful to display the
      username. This is unique and can help support identifying issues.
      
      Closes #131
      aa10b70f
  18. Apr 11, 2018
  19. Apr 09, 2018
Loading