As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
  1. Nov 15, 2021
  2. Nov 12, 2021
  3. Nov 11, 2021
    • Stan Hu's avatar
      Relax key and username matching for sshd · 672013e7
      Stan Hu authored
      Due to the way sshd works, gitlab-shell could be called with a single
      string in the form:
      
      ```
      /path/to/gitlab-shell -c key-id
      ```
      
      However, due to the tightening of the regular expressions in fcff692b
      this string no longer matches, so logins would fail with:
      
      ```
      Failed to get username: who='' is invalid
      ```
      
      This can be reproduced by changing the user's shell to point to
      gitlab-shell. For example:
      
      ```
      usermod git -s /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell
      ```
      
      While setting gitlab-shell as the user's shell isn't officially
      supported, gitlab-shell still should be able to cope with the key being
      specified as the last argument. We now split the argument list and use
      the last value.
      
      Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/530
      Unverified
      672013e7
  4. Oct 21, 2021
  5. Oct 20, 2021
  6. Oct 13, 2021
  7. Oct 12, 2021
  8. Oct 07, 2021
  9. Oct 06, 2021
    • Igor Drozdov's avatar
      Merge branch 'fix-logging-channel-type' into 'main' · 83f76b49
      Igor Drozdov authored
      Fix logging channel type
      
      See merge request gitlab-org/gitlab-shell!534
      83f76b49
    • Nick Thomas's avatar
      Fix logging channel type · b33de0ed
      Nick Thomas authored
      Currently we get this in some log messages:
      
      logrus_error="can not add field \"channel_type\""
      
      This is because we're trying to add a function, rather than the result
      of the function call (a string) to the `log.Fields`. Whoops!
      
      Changelog: fixed
      b33de0ed
  10. Oct 01, 2021
  11. Sep 30, 2021
  12. Sep 28, 2021
  13. Sep 27, 2021
  14. Sep 23, 2021
  15. Sep 20, 2021
Loading