As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects

Passing pushauth flag as bool in json body to internal api doesn't become a...

Open Manoj Memana Jayakumar requested to merge mmj/gitlab-shell:506-jsandlin into main
1 file
+ 2
4
Compare changes
  • Side-by-side
  • Inline
@@ -24,13 +24,13 @@ describe 'bin/gitlab-shell 2fa_verify' do
key_id = params['key_id'] || params['user_id'].to_s
if key_id == '100'
if params['push_auth']
if params['push_auth'] == "true"
res.body = { success: false }.to_json
else
res.body = { success: true }.to_json
end
elsif key_id == '102'
if params['push_auth']
if params['push_auth'] == "true"
res.body = { success: true }.to_json
end
else
@@ -99,8 +99,6 @@ describe 'bin/gitlab-shell 2fa_verify' do
Open3.popen2(env, cmd) do |stdin, stdout|
expect(stdout.gets(5)).to eq('OTP: ')
stdin.puts('123456')
expect(stdout.flush.read).to eq("\nPush OTP validation successful. Git operations are now allowed.\n")
end
end
Loading