Merge branch '695-remove-nilaway-detections-for-client-package' into 'main'

Resolve "Remove NilAway detections for 'client' package"

Closes #695

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/896



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Approved-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Ash McKenzie <amckenzie@gitlab.com>

client/gitlabnet.go

@@ -106,7 +106,7 @@ func newRequest(ctx context.Context, method, host, path string, data interface{}
 }
 
 func parseError(resp *http.Response, respErr error) error {
-	if respErr != nil {
+	if resp == nil || respErr != nil {
 		return &ApiError{"Internal API unreachable"}
 	}
 

client/httpclient_test.go

@@ -68,6 +68,7 @@ func testBasicAuthHeaders(t *testing.T, response *http.Response) {
 	require.NoError(t, err)
 
 	headerParts := strings.Split(string(responseBody), " ")
+	require.NotNil(t, headerParts)
 	require.Equal(t, "Basic", headerParts[0])
 
 	credentials, err := base64.StdEncoding.DecodeString(headerParts[1])