Merge branch 'ashmckenzie/enable-testifylint' into 'main'

golangci updates and enable testifylint

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/900



Merged-by: Stan Hu <stanhu@gmail.com>
Approved-by: Stan Hu <stanhu@gmail.com>
Co-authored-by: Ash McKenzie <amckenzie@gitlab.com>

.golangci.yml

@@ -109,9 +109,6 @@ linters-settings:
     # disable:
     #   - shadow
     # disable-all: false
-  golint:
-    # minimal confidence for issues, default is 0.8
-    min-confidence: 0.8
   gofmt:
     # simplify code: gofmt with `-s` option, true by default
     simplify: true
@@ -246,6 +243,7 @@ linters:
     - dogsled
     - dupl
     - errcheck
+    - exportloopref
     - funlen
     - gocognit
     - goconst
@@ -253,7 +251,6 @@ linters:
     - godox
     - gofmt
     - goimports
-    - golint
     - gosec
     - gosimple
     - govet
@@ -261,10 +258,10 @@ linters:
     - interfacer
     - misspell
     - nakedret
-    - scopelint
+    - revive
     - staticcheck
-    - structcheck
     - stylecheck
+    - testifylint
     - typecheck
     - unconvert
     - unparam

Makefile

@@ -13,7 +13,7 @@ GOTESTSUM_VERSION := 1.10.0
 GOTESTSUM_VERSION_ARCH ?= ${ARCH}
 GOTESTSUM_FILE := support/bin/gotestsum-${GOTESTSUM_VERSION}
 
-GOLANGCI_LINT_VERSION := 1.54.2
+GOLANGCI_LINT_VERSION := 1.55.2
 GOLANGCI_LINT_ARCH ?= ${ARCH}
 GOLANGCI_LINT_FILE := support/bin/golangci-lint-${GOLANGCI_LINT_VERSION}