As we reevaluate how to best support and maintain Staging Ref in the future, we encourage development teams using this environment to highlight their use cases in the following issue: https://gitlab.com/gitlab-com/gl-infra/software-delivery/framework/software-delivery-framework-issue-tracker/-/issues/36.

Skip to content
Snippets Groups Projects
Unverified Commit 994d76bd authored by Igor Drozdov's avatar Igor Drozdov
Browse files

Revert sending SSH certificate as a separate protocol

Gitlab Rails now restricts SSH protocol access via an
additional boolean setting rather than a separate Git
protocol
parent e4c449fe
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -13,9 +13,8 @@ import (
)
const (
sshProtocol = "ssh"
sshCertProtocol = "ssh_certificates"
anyChanges = "_any"
sshProtocol = "ssh"
anyChanges = "_any"
)
type Client struct {
Loading
Loading
@@ -93,10 +92,6 @@ func (c *Client) Verify(ctx context.Context, args *commandargs.Shell, action com
NamespacePath: args.Env.NamespacePath,
}
if args.Env.NamespacePath != "" {
request.Protocol = sshCertProtocol
}
if args.GitlabUsername != "" {
request.Username = args.GitlabUsername
} else if args.GitlabKrb5Principal != "" {
Loading
Loading
Loading
Loading
@@ -266,7 +266,6 @@ func setup(t *testing.T, userResponses, keyResponses map[string]testResponse) *C
_, err := w.Write(tr.body)
require.NoError(t, err)
require.Equal(t, namespace, requestBody.NamespacePath)
require.Equal(t, sshCertProtocol, requestBody.Protocol)
} else if tr, ok := userResponses[requestBody.Krb5Principal]; ok {
w.WriteHeader(tr.status)
_, err := w.Write(tr.body)
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment