Merge branch 'id-remove-redundant-code' into 'main'

Remove Gitlab-Shared-Secret reference that is no longer used

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/985



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Reviewed-by: Ash McKenzie <amckenzie@gitlab.com>
Co-authored-by: Igor Drozdov <idrozdov@gitlab.com>

client/client_test.go

@@ -258,12 +258,6 @@ func buildRequests(t *testing.T, relativeURLRoot string) []testserver.TestReques
 				fmt.Fprint(w, "Echo: "+string(b))
 			},
 		},
-		{
-			Path: "/api/v4/internal/auth",
-			Handler: func(w http.ResponseWriter, r *http.Request) {
-				fmt.Fprint(w, r.Header.Get(secretHeaderName))
-			},
-		},
 		{
 			Path: "/api/v4/internal/jwt_auth",
 			Handler: func(w http.ResponseWriter, r *http.Request) {

client/gitlabnet.go

@@ -16,7 +16,6 @@ import (
 
 const (
 	internalApiPath     = "/api/v4/internal"
-	secretHeaderName    = "Gitlab-Shared-Secret"
 	apiSecretHeaderName = "Gitlab-Shell-Api-Request"
 	defaultUserAgent    = "GitLab-Shell"
 	jwtTTL              = time.Minute