Merge branch '671-race-golang-1-x-failed-with-stdin-send-error-eof-2-1' into 'main'

Move global tempDir into StartSocketHttpServer()

Closes #671

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/902



Merged-by: Igor Drozdov <idrozdov@gitlab.com>
Co-authored-by: Ash McKenzie <amckenzie@gitlab.com>

client/testserver/testserver.go

@@ -17,11 +17,6 @@ import (
 	"gitlab.com/gitlab-org/gitlab-shell/v14/internal/testhelper"
 )
 
-var (
-	tempDir, _ = os.MkdirTemp("", "gitlab-shell-test-api")
-	testSocket = path.Join(tempDir, "internal.sock")
-)
-
 type TestRequestHandler struct {
 	Path    string
 	Handler func(w http.ResponseWriter, r *http.Request)
@@ -30,9 +25,12 @@ type TestRequestHandler struct {
 func StartSocketHttpServer(t *testing.T, handlers []TestRequestHandler) string {
 	t.Helper()
 
+	tempDir, _ := os.MkdirTemp("", "gitlab-shell-test-api")
+	t.Cleanup(func() { os.RemoveAll(tempDir) })
+
+	testSocket := path.Join(tempDir, "internal.sock")
 	err := os.MkdirAll(filepath.Dir(testSocket), 0700)
 	require.NoError(t, err)
-	t.Cleanup(func() { os.RemoveAll(tempDir) })
 
 	socketListener, err := net.Listen("unix", testSocket)
 	require.NoError(t, err)