Release v13.19.0

See merge request gitlab-org/gitlab-shell!482

Add acceptance test for git-upload-pack

See merge request gitlab-org/gitlab-shell!477

fix: upgrade of the gitaly dependency

See merge request gitlab-org/gitlab-shell!481

Gitaly project now properly respects module release flow
and includes a module suffix in the package name. It requires
to re-write all non-suffixed imports with suffixed of a specific
version of tha module. With proper module versioning we don't
need to use a 'replace' directive to point to specific commit
and can use semantic versioning for the gitaly dependency.

Part of: https://gitlab.com/gitlab-org/gitaly/-/issues/3177

Unit test wrong channel type

See merge request gitlab-org/gitlab-shell!479

Contributes to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/500

Add acceptance test for git-upload-archive

See merge request gitlab-org/gitlab-shell!478

Contributes to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/500

Fix opentracing setup for gitlab-sshd

Closes #501

See merge request gitlab-org/gitlab-shell!473

Add first Gitaly acceptance test

See merge request gitlab-org/gitlab-shell!475

fix: upgrade of the labkit dependency

See merge request gitlab-org/gitlab-shell!474

The labkit has a fix in the dependency chain b36f912 (Merge branch 'ps-fix-dep-version' into 'master', 2021-05-20).

1.4.0 has introduced the format change
Since v1 means latest 1.* image, we're pulling the unsupported version

Acceptance tests for 2fa_recovery_codes, 2fa_verify, and git-lfs-authenticate

See merge request gitlab-org/gitlab-shell!472

Previously, opentracing (if configured) was initialized late in the
gitlab-shell process's lifespan, coming just before making a gRPC
call to Gitaly.

By moving the opentracing initialization to be at process startup, we
make it available for the whole process lifecycle, which is very useful
to gitlab-sshd, as it means we'll only call tracing.Initialize() once
on process startup, rather than once per SSH connection.

To get this working, we need to introduce a context to gitlab-sshd.
This carries the client/service name, but also carries an initial
correlation ID. The main outcome of this is that all calls to the
authorized_keys endpoint from a given gitlab-sshd process will now
share a correlation ID. I don't have a strong opinion about this either
way.

Changelog: fixed

Add acceptance test for personal_access_token command

See merge request gitlab-org/gitlab-shell!471

Respect parent context for Gitaly calls

See merge request gitlab-org/gitlab-shell!469

Stop changing directory to the filesystem root

See merge request gitlab-org/gitlab-shell!470

This behaviour dates from when Gitaly RPCs were executed in Ruby by a
Go subprocess. It's not needed for gitlab-shell now that it's in Go,
and it's a very strange thing for gitlab-sshd. Best just to remove it.

If we wanted to retain this behaviour, we could have an `os.Chdir` call
in the gitlab-shell binary, but I just don't think it's needed.

Changelog: fixed

Without these changes, Gitaly calls would not be linked to a parent
context. This means that they would have an unassociated correlationID,
and Gitaly RPC calls would not be cancel()ed by parent context
cancellation.

Changelog: fixed

Update LabKit to v1.4.0

Closes #478

See merge request gitlab-org/gitlab-shell!468

gitlab-sshd: Respect the ssl_cert_dir config

Closes #516

See merge request gitlab-org/gitlab-shell!467

Don't finish the opentracing span early

See merge request gitlab-org/gitlab-shell!466

Changelog: fixed

Calling finished() in `ContextWithCorrelationID` breaks opentracing,
since it expects us to call it just before exiting, and this defer
runs on function completion.

All existing users of ContextWithCorrelationID already `defer finish()`
themselves, so this call is entirely surplus to requirements.

Release v13.18.0

See merge request gitlab-org/gitlab-shell!465

sshd: Recover from per-session and per-connection panics

Closes #511

See merge request gitlab-org/gitlab-shell!464

Without this, a failure in a single session could take out a whole
connection, or a failure in a single connection could take out the
whole server.

Extract sshd connections and sessions into their own files and structs

See merge request gitlab-org/gitlab-shell!463