- Jul 15, 2022
-
-
Stan Hu authored
- Update LabKit library to v1.16.0 !668 (https://gitlab.com/gitlab-org/labkit/-/releases/v1.16.0)
-
- Jul 13, 2022
-
-
Stan Hu authored
Update LabKit library to v1.16.0 See merge request gitlab-org/gitlab-shell!668
-
Alejandro Rodríguez authored
* include original address in correlation CIDR checks ([ae96001](https://gitlab.com/gitlab-org/labkit/commit/ae9600163a6f5fa2ad06676a00b310af36573df4)) * run make recipes in parallel during backward compat check ([efa9c71](https://gitlab.com/gitlab-org/labkit/commit/efa9c71e13ef2bfe4415278e6b1e5c5ee8cc8022)) See https://gitlab.com/gitlab-org/labkit/-/releases/v1.16.0
-
- Jul 05, 2022
-
-
Igor Drozdov authored
Release v14.8.0 See merge request gitlab-org/gitlab-shell!667
-
Igor Drozdov authored
- go: Bump major version to v14 !666 - Pass original IP from PROXY requests to internal API calls !665 - Fix make install copying the wrong binaries !664 - gitlab-sshd: Add support for configuring host certificates !661
-
Igor Drozdov authored
go: Bump major version to v14 Closes #593 See merge request gitlab-org/gitlab-shell!666
-
Patrick Steinhardt authored
While gitlab-shell currently has a major version of v14, the module path it exposes is not using that major version like it is required by the Go standard. This makes it impossible for dependents to import gitlab-shell as a dependency without using a commit as version. Fix this by changing the module path of gitlab-shell to instead be `gitlab.com/gitlab-org/gitlab-shell/v14` and adjust all imports accordingly. Changelog: fixed
-
- Jul 01, 2022
-
-
Igor Drozdov authored
Pass original IP from PROXY requests to internal API calls See merge request gitlab-org/gitlab-shell!665
-
- Jun 30, 2022
-
-
Alejandro Rodríguez authored
-
- Jun 29, 2022
-
-
Igor Drozdov authored
gitlab-sshd: Add support for configuring host certificates See merge request gitlab-org/gitlab-shell!661
-
- Jun 26, 2022
-
-
Stan Hu authored
This adds support for specifying host certificates via the `host_cert_files` option and advertises the signed key to the client. This acts similarly to OpenSSH's `HostCertificate` parameter: gitlab-sshd attempts to match a host key to its certificate, and then substitutes the matching host key with a certificate signed by a trusted certificate authority's key. This is the first requirement to supporting SSH certificates. This will enable the client to trust the server if both trust a common certificate authority. The `TrustedUserCAKeys` option will need to be supported later for the server to trust all user keys signed by this certificate authority. Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/495
-
- Jun 23, 2022
-
-
Igor Drozdov authored
Fix make install copying the wrong binaries See merge request gitlab-org/gitlab-shell!664
-
Stan Hu authored
While testing https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1062, we found `make install` was not copying the right binaries, such as `gitlab-shell-authorized-keys-check`. This might have originally been written with a single binary in mind (https://gitlab.com/gitlab-org/gitlab-shell/-/issues/207). Changelog: fixed
-
- Jun 16, 2022
-
-
Igor Drozdov authored
Release v14.7.4 See merge request gitlab-org/gitlab-shell!663
-
Igor Drozdov authored
- Update crypto module to fix RSA keys with old gpg-agent
-
Igor Drozdov authored
gitlab-sshd: Update crypto module to fix RSA keys with old gpg-agent See merge request gitlab-org/gitlab-shell!662
-
Stan Hu authored
When we put gitlab-sshd in production, we noticed a number of clients using RSA keys would fail to login. The server would report: ``` ssh: signature "ssh-rsa" not compatible with selected algorithm "rsa-sha2-512" ``` This is reproducible on Ubuntu 18.04, which ships gpg-agent v2.2.4 and OpenSSH v7.6. That version of gpg-agent does not support `rsa-sha2-256` or `rsa-sha2-512`, but OpenSSH does. As a result, OpenSSH specifies `rsa-sha-512` as the public key algorithm to use in the user authentication request message, but gpg-agent includes an `ssh-rsa` signature. OpenSSH servers tolerates this discrepancy, but the Go implementation fails because it expects a strict match. This commit pulls in https://gitlab.com/gitlab-org/golang-crypto/-/merge_requests/9 to fix the problem. Relates to: 1. https://github.com/golang/go/issues/53391 2. https://gitlab.com/gitlab-org/gitlab-shell/-/issues/587 Changelog: fixed
-
- Jun 14, 2022
-
-
Igor Drozdov authored
Set BUNDLE_FROZEN to true Closes #562 See merge request gitlab-org/gitlab-shell!659
-
- Jun 10, 2022
-
-
Alejandro Rodríguez authored
To follow rubygems' security adisory https://github.com/rubygems/rubygems.org/security/advisories/GHSA-hccv-rwq6-vh79:
-
- Jun 07, 2022
-
-
Igor Drozdov authored
Upgrade Gemfile.lock to use bundler to v2.3.15 See merge request gitlab-org/gitlab-shell!658
-
Stan Hu authored
This is just to minimize the versions of bundler used for development. The GDK runs `support/bundle-install` in this directory to obtain the version of bundler needed. This relates to https://gitlab.com/gitlab-org/gitlab/-/issues/364373.
-
- Jun 06, 2022
-
-
Igor Drozdov authored
Release v14.7.3 See merge request gitlab-org/gitlab-shell!657
-
Igor Drozdov authored
- Ignore "not our ref" errors from gitlab-sshd error metrics
-
Igor Drozdov authored
Ignore "not our ref" errors from gitlab-sshd error metrics See merge request gitlab-org/gitlab-shell!656
-
Stan Hu authored
If a client requests a ref that cannot be found in the repository, previously gitlab-sshd would record it as part of its service level indicator metric. This is really an application error between the client and the Git repository, so we exclude it from our metrics. Relates to https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/15848 Changelog: fixed
-
Igor Drozdov authored
Release 14.7.2 See merge request gitlab-org/gitlab-shell!655
-
Igor Drozdov authored
- Exclude disallowed command from error rate
-
Patrick Bajao authored
Exclude disallowed command from error rate See merge request gitlab-org/gitlab-shell!654
-
- Jun 01, 2022
-
-
Igor Drozdov authored
-
- May 25, 2022
-
-
Igor Drozdov authored
Release 14.7.1 See merge request gitlab-org/gitlab-shell!652
-
Igor Drozdov authored
- Log gitlab-sshd session level indicator errors !650 - Improve establish session duration metrics !651
-
Stan Hu authored
Calculate session start after the connection is established See merge request gitlab-org/gitlab-shell!653
-
Igor Drozdov authored
-
Stan Hu authored
Improve establish session duration metrics See merge request gitlab-org/gitlab-shell!651
-
Igor Drozdov authored
Before we took into account the time a user takes to authenticate Now it only measures the time between a connection established and a command started to being executed It's still can be controlled by a user, but it's something we can measure and restrict if necessary
-
Igor Drozdov authored
Log gitlab-sshd session level indicator errors See merge request gitlab-org/gitlab-shell!650
-
- May 24, 2022
-
-
Stan Hu authored
In production, we saw gitlab-sshd error metrics rise, but it was not clear why. We now log a message every time we encounter a session error that affects the service level indicator counter.
-
Igor Drozdov authored
Document gitlab-shell on GitLab SaaS See merge request gitlab-org/gitlab-shell!625
-
- May 23, 2022